Fix bookWhen field is null in the Transmodel API#6385
Merged
Conversation
t2gran
added
!Bug
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6385 +/- ##
==========================================
Coverage 69.79% 69.80%
- Complexity 17939 17942 +3
==========================================
Files 2046 2046
Lines 76678 76678
Branches 7830 7830
==========================================
+ Hits 53521 53524 +3
+ Misses 20414 20412 -2
+ Partials 2743 2742 -1 ☔ View full report in Codecov by Sentry. |
leonardehrenfried
approved these changes
Jan 14, 2025
vpaturet
approved these changes
Jan 15, 2025
t2gran
added
Entur Test
t2gran
pushed a commit
that referenced
this pull request
Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
bookWhenfield in booking-info is not populated in the Transmodel API any more. This is a regression. The problem was introduced in f312144.Issue
Closes #6384
Unit tests
🟥 This is a critical fix - writing a unit test for this require refactoring. The implementation is imperative and the business rules is not encapsulated. So, I have not provided any test - that would introduce extra risk.
Documentation
🟥 Not relevant
Changelog
✅ Should be included
Bumping the serialization version id
🟥 No changes to the serialized model