Replacing protobuf-format in SIRI-Updater with standard xml#6409
Merged
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6409 +/- ##
==========================================
Coverage 69.79% 69.79%
Complexity 18089 18089
==========================================
Files 2064 2064
Lines 77209 77208 -1
Branches 7859 7859
==========================================
Hits 53886 53886
Misses 20566 20566
+ Partials 2757 2756 -1 ☔ View full report in Codecov by Sentry. |
leonardehrenfried
approved these changes
Jan 31, 2025
vpaturet
approved these changes
Feb 7, 2025
Member
|
It seems that the new CI workflow is somehow not triggered since this PR was opened beforehand. Let me know if you want me to admin-merge this. |
Contributor
|
@leonardehrenfried yes, please merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the usage of proprietary protobuf-format for SIRI ET-data with standard XML.
Issue
The protobuf-solution was very sensitive to changes, and upgrading protobuf-java (e.g. as in #6342) caused OTP to no longer being able to process SIRI ET-data.