Add 'boardCost' parameter for cars#6413
Merged
optionsome merged 5 commits intoFeb 3, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6413 +/- ##
==========================================
Coverage 69.84% 69.84%
Complexity 18125 18125
==========================================
Files 2069 2069
Lines 77268 77293 +25
Branches 7855 7858 +3
==========================================
+ Hits 53965 53983 +18
- Misses 20546 20551 +5
- Partials 2757 2759 +2 ☔ View full report in Codecov by Sentry. |
VillePihlava
changed the title
optionsome
changed the title
optionsome
added
+Config Change
leonardehrenfried
left a comment
leonardehrenfried
left a comment
Member
There was a problem hiding this comment.
This is clean and has good documentation. 👍
If you fulfil Joel's requests, this is good to merge.
leonardehrenfried
approved these changes
Jan 31, 2025
optionsome
approved these changes
Feb 3, 2025
t2gran
pushed a commit
that referenced
this pull request
Feb 3, 2025
t2gran
pushed a commit
that referenced
this pull request
Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a boardCost parameter for cars to the router config. This is similar to what can currently be found for walking and cycling. This can improve car transit routing results.
Issue
This is a follow-up PR related to issue #5875
Unit tests
I added more checks to existing unit tests related to the additions.
Documentation
Changes to
RouteRequest.mdandRouterConfiguration.md.