Skip to content

Support for coordinates in via search - #6477

Merged
t2gran merged 43 commits into
opentripplanner:dev-2.xfrom
entur:via_coordinate
Mar 3, 2025
Merged

Support for coordinates in via search#6477
t2gran merged 43 commits into
opentripplanner:dev-2.xfrom
entur:via_coordinate

Conversation

@t2gran

@t2gran t2gran commented Feb 21, 2025

Copy link
Copy Markdown
Member

Summary

Explain in one or two sentences what this PR achieves.

Issue

This is part of #4887 and fixes the top bullet point: #4887 (comment)

Unit tests

✅ I have added unit-test on some of the existing features witch did not have sufficent test covarage
✅ I also added module tests on the via coordinate raptor implementation
✅ I have fixed part of the broken Itinerary mapping tests

Documentation

✅ JavaDoc
✅ Transmodel API doc on via-coordinate

Changelog

✅ Should be included

Bumping the serialization version id

Not needed. There is no changes to the state of domain classes. StreetEdge is changed, but this should work ok with serialization. The enum LinkingDirection is changed, but this should not be serialized.

@t2gran t2gran added !New Feature A functional feature targeting the end user. Entur On Entur Roadmap Entur Test This is currently being tested at Entur labels Feb 21, 2025
@t2gran t2gran added this to the 2.7 (next release) milestone Feb 21, 2025
@t2gran
t2gran requested a review from a team as a code owner February 21, 2025 09:59
@codecov

codecov Bot commented Feb 21, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 74.79675% with 93 lines in your changes missing coverage. Please review.

Project coverage is 70.13%. Comparing base (caf673b) to head (7fb79a7).
Report is 72 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
...a/service/DefaultViaCoordinateTransferFactory.java 10.20% 44 Missing ⚠️
...algorithm/mapping/RaptorPathToItineraryMapper.java 55.17% 11 Missing and 2 partials ⚠️
...anner/routing/via/model/ViaCoordinateTransfer.java 63.15% 7 Missing ⚠️
...m/raptoradapter/transit/DefaultRaptorTransfer.java 76.19% 5 Missing ⚠️
...routing/algorithm/raptoradapter/path/PathDiff.java 0.00% 4 Missing ⚠️
...pplanner/raptor/api/request/RaptorViaLocation.java 92.30% 2 Missing and 1 partial ⚠️
...planner/ext/restapi/resources/PlannerResource.java 0.00% 2 Missing ⚠️
...oradapter/transit/mappers/RaptorRequestMapper.java 90.00% 1 Missing and 1 partial ⚠️
...igure/TransferOptimizationServiceConfigurator.java 33.33% 1 Missing and 1 partial ⚠️
...entripplanner/routing/via/configure/ViaModule.java 0.00% 2 Missing ⚠️
... and 7 more
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6477      +/-   ##
=============================================
+ Coverage      70.10%   70.13%   +0.02%     
- Complexity     18270    18298      +28     
=============================================
  Files           2077     2079       +2     
  Lines          77654    77743      +89     
  Branches        7826     7822       -4     
=============================================
+ Hits           54440    54524      +84     
- Misses         20436    20454      +18     
+ Partials        2778     2765      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vpaturet vpaturet removed the Entur Test This is currently being tested at Entur label Feb 27, 2025
Comment thread raptor/src/main/java/org/opentripplanner/raptor/path/PathBuilderLeg.java Outdated
t2gran and others added 3 commits February 27, 2025 18:34
Co-authored-by: Joel Lappalainen <lappalj8@gmail.com>
The feature this code adressed is solved elsewhere.
@t2gran
t2gran requested a review from optionsome February 27, 2025 17:58
optionsome
optionsome previously approved these changes Feb 27, 2025
@t2gran
t2gran merged commit 98459e1 into opentripplanner:dev-2.x Mar 3, 2025
@t2gran
t2gran deleted the via_coordinate branch March 3, 2025 16:50
t2gran pushed a commit that referenced this pull request Mar 3, 2025
@miklcct

miklcct commented Mar 12, 2025

Copy link
Copy Markdown
Contributor

I have just read this PR and want to add the functionality to my client for OTP 2.7.0, but the GTFS GraphQL API still says that "Coordinates are NOT supported yet." for the visit via points. Can anyone explain to me what this PR has achieved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Entur On Entur Roadmap !New Feature A functional feature targeting the end user.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants