Fix rounding error in street routing - #6484
Merged
tkalvas merged 9 commits intoMar 3, 2025
Merged
Conversation
…reating the reversed path for arriveBy queries
…ange to work with changed arriveBy time rounding logic
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6484 +/- ##
=============================================
+ Coverage 70.10% 70.13% +0.02%
+ Complexity 18273 18269 -4
=============================================
Files 2077 2077
Lines 77658 77620 -38
Branches 7827 7820 -7
=============================================
- Hits 54443 54439 -4
+ Misses 20438 20402 -36
- Partials 2777 2779 +2 ☔ View full report in Codecov by Sentry. |
tkalvas
marked this pull request as ready for review
February 26, 2025 10:33
tkalvas
marked this pull request as draft
February 26, 2025 10:36
Contributor
Author
|
Ok, now I no longer change anything of note. I'm not sure where the problem originates from. |
tkalvas
marked this pull request as ready for review
February 26, 2025 10:39
Contributor
Author
|
The truncation was wrong, so the check is wrong, and there never was anything actually incorrect. |
vpaturet
self-requested a review
February 26, 2025 11:59
optionsome
reviewed
Feb 26, 2025
optionsome
changed the title
optionsome
added
the
!Bug
…eRequest datetime to be an exact number of seconds. Backward and forward searches will now not match unless the request datetime is an exact number of seconds.
tkalvas
marked this pull request as draft
February 27, 2025 13:47
Contributor
Author
|
There's still a place where I have to round the input time to a whole second in RouteRequest, I'll do it today, and then undraft the pr. |
tkalvas
marked this pull request as ready for review
February 27, 2025 13:54
optionsome
reviewed
Feb 27, 2025
vpaturet
requested changes
Feb 27, 2025
| ) { | ||
| OTPRequestTimeoutException.checkForTimeout(); | ||
| Instant reqTime = request.dateTime().truncatedTo(ChronoUnit.SECONDS); | ||
| Instant reqTime = request.dateTime().truncatedTo(ChronoUnit.MILLIS); |
Contributor
There was a problem hiding this comment.
is it necessary to truncate again here? It seems that the unit tests pass even without truncating.
Contributor
Author
There was a problem hiding this comment.
This has become unnecessary due to later changes. I'm taking it out.
optionsome
approved these changes
Mar 3, 2025
vpaturet
approved these changes
Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix inaccuracy in state reversal which generates rounding errors in creating the reversed path for arriveBy queries
Summary
Explain in one or two sentences what this PR achieves.
Issue
Fixes #6481
Unit tests
Added a bit of testing for the reversal code to work accurately no matter what the millisecond part of the time in the request.
Changelog
Not needed, bug fix for a new fix.
Bumping the serialization version id
No.