Improve street routing within concave parts of area holes - #6486
Merged
vesameskanen merged 14 commits intoFeb 26, 2025
Conversation
It turns out that concave parts of areas may not have any connection to visibilkity nodes of the graph. Edges of area holes muts be included in the graph.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6486 +/- ##
==========================================
Coverage 70.10% 70.10%
- Complexity 18269 18270 +1
==========================================
Files 2077 2077
Lines 77659 77654 -5
Branches 7828 7826 -2
==========================================
+ Hits 54439 54441 +2
+ Misses 20439 20437 -2
+ Partials 2781 2776 -5 ☔ View full report in Codecov by Sentry. |
Member
|
Please pull these changes: leonardehrenfried@25f37a9 |
Member
|
The test we wrote today is now available here: https://github.com/leonardehrenfried/OpenTripPlanner/tree/keep-interior-rings |
optionsome
reviewed
Feb 26, 2025
leonardehrenfried
previously approved these changes
Feb 26, 2025
optionsome
approved these changes
Feb 26, 2025
leonardehrenfried
approved these changes
Feb 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Street graph building has been pruning the graph built for open areas too aggressively. It left the edges needed for passing through areas, but routing from locations obscured by complex area hole geometries was not always successful.
This PR adds the required hole edges to the street graph so that area routing never fails. Another minor improvement is optimized addition of area visibility points.
Before:
After:
