Repository navigation
Use default max stop count for mode from routing defaults in transfer requests - #6494
Merged
optionsome merged 9 commits intoMar 4, 2025
Merged
optionsome merged 9 commits into
optionsome merged 9 commits into
Conversation
This also fixes and issue with default values being overridden
optionsome
added
!Bug
optionsome
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6494 +/- ##
=============================================
+ Coverage 70.09% 70.12% +0.03%
+ Complexity 18293 18285 -8
=============================================
Files 2079 2078 -1
Lines 77781 77707 -74
Branches 7830 7836 +6
=============================================
- Hits 54518 54492 -26
+ Misses 20496 20436 -60
- Partials 2767 2779 +12 ☔ View full report in Codecov by Sentry. |
optionsome
force-pushed
the
maxStopCountForMode-default-fix
branch
from
February 26, 2025 15:08
1875486 to
5889c90
Compare
optionsome
marked this pull request as ready for review
February 26, 2025 16:33
optionsome
requested review from
VillePihlava and
leonardehrenfried
and removed request for
VillePihlava
February 26, 2025 19:35
VillePihlava
requested changes
Feb 27, 2025
VillePihlava
left a comment
VillePihlava
left a comment
Contributor
There was a problem hiding this comment.
This looks good. I could not find anything significant just a couple of nits
Co-authored-by: Ville Pihlava <ville.pihlava@gmail.com>
VillePihlava
approved these changes
Feb 28, 2025
leonardehrenfried
approved these changes
Mar 4, 2025
leonardehrenfried
left a comment
leonardehrenfried
left a comment
Member
There was a problem hiding this comment.
I approve this but if you could give this a better PR title that would be nice.
optionsome
changed the title
t2gran
pushed a commit
that referenced
this pull request
Mar 4, 2025
t2gran
pushed a commit
that referenced
this pull request
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor max stop count limit so that the map is merged with any new definition of max stop counts. This also fixes an issue with default max stop count limit for mode being overridden by an empty map when using transfer cache requests.
This replaces #6488
Issue
No issue
Unit tests
Updated
Documentation
Not needed
Changelog
From title