Add debug layer for rental entities - #6520
Conversation
leonardehrenfried
added
the
+OTP Debug UI
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6520 +/- ##
==========================================
Coverage 70.17% 70.18%
- Complexity 18312 18318 +6
==========================================
Files 2082 2084 +2
Lines 77211 77278 +67
Branches 7831 7834 +3
==========================================
+ Hits 54184 54234 +50
- Misses 20257 20272 +15
- Partials 2770 2772 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
cc @fpurcell |
| protected Collection<KeyValue> map(VehicleRentalPlace input) { | ||
| return List.of( | ||
| kv("class", input.getClass().getSimpleName()), | ||
| kv("id", input.getName()), | ||
| kv("network", input.getNetwork()), | ||
| kv("vehiclesAvailable", input.getVehiclesAvailable()), | ||
| kv("spacesAvailable", input.getSpacesAvailable()) | ||
| ); |
There was a problem hiding this comment.
Perhaps you could also add information about if the station/vehicle is disabled or not.
There was a problem hiding this comment.
Ah I'm sorry didn't remember we even had these disabled vehicles/spaces. I meant the isRenting/isReturning type of information. I'm not sure how often this disabled vehicle/space information is provided by the data feeds in cases where the station is not in service. We can include both information if you want.
habrahamsson-skanetrafiken
left a comment
habrahamsson-skanetrafiken
left a comment
There was a problem hiding this comment.
Looks good to me
4 participants
Summary
It adds a debug layer for displaying vehicle rental entities in the debug UI.
Unit tests
Updated.