Repository navigation
Allow filtering of intermediate stops in GraphQL API - #6725
Conversation
2ff3d64 to
74ab1e4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6725 +/- ##
=============================================
+ Coverage 71.76% 71.79% +0.02%
- Complexity 19063 19091 +28
=============================================
Files 2066 2067 +1
Lines 77713 77781 +68
Branches 7921 7934 +13
=============================================
+ Hits 55773 55845 +72
+ Misses 19119 19112 -7
- Partials 2821 2824 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
74ab1e4 to
3a74e0c
Compare
| "A group of stops. Introduced by the GTFS-Flex spec process." | ||
| LOCATION_GROUP |
There was a problem hiding this comment.
Are the locations always regular stops or can they be geojson locations? I had a feeling that they might be mostly geojson locations, but I couldn't make sense by reading the docs for a minute :D.
There was a problem hiding this comment.
In the spec they must be stops but since OTP implemented an earlier draft we allow them to be locations, too. :)
I agree that the name location group is confusing, but people couldn't face another round of renaming at the end of the spec process. "Stop areas" was also already taken. "Stop groups" would have probably been the correct name.
There was a problem hiding this comment.
I can call them STOP_GROUP in the schema.
There was a problem hiding this comment.
Not sure, maybe using the GTFS terminology here is fine.
51e1fbb to
8a51f13
Compare
|
I've removed the filtering from intermediatePlaces completely. |
optionsome
left a comment
There was a problem hiding this comment.
Just update the pr title/description.
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
LGTM with naming nitpicks.
| .withAlightStopIndexInPattern(4) | ||
| .withTripPattern(PATTERN) | ||
| .build(); | ||
| private static final LegImpl SUBJECT = new LegImpl(); |
There was a problem hiding this comment.
Rename this variable maybe?
| } | ||
|
|
||
| @Test | ||
| void intermediateStopsWithInclude() throws Exception { |
There was a problem hiding this comment.
| void intermediateStopsWithInclude() throws Exception { | |
| void intermediateStopsWithFilter() throws Exception { |
| } | ||
|
|
||
| @Test | ||
| void walkLegWithInclude() throws Exception { |
There was a problem hiding this comment.
| void walkLegWithInclude() throws Exception { | |
| void walkLegWithFilter() throws Exception { |
|
@binh-dam-ibigroup I added your suggestions directly to dev-2.x: c3bdc36 |
Summary
Allows the itinerary's
intermediatePlacesandintermediateStopsfields to be optionally filtered by stop type.This is useful if you have trips that mix flex and static stops and you're only interested in seeing a particular type.
Unit tests
Lots added.
Documentation
Schema and Javadoc.
Requested by @miles-grant-ibigroup