Handle alerts for stations - #6750
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6750 +/- ##
==========================================
Coverage ? 71.87%
Complexity ? 19132
==========================================
Files ? 2074
Lines ? 77763
Branches ? 7936
==========================================
Hits ? 55890
Misses ? 19064
Partials ? 2809 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
My first gut feeling is that this is the correct thing to do, but does the spec explicity talk about this? |
The spec does not limit the application of alerts to platforms / stations / corridors / entrances / etc. For example, you can set the affected entity to reference a In particular, "Loading alerts for a stop should return alerts for that stop, and for the parent station in the GTFS-RT feed." is open to discussion but there has already been a TODO for years in the code which I have been completed. Also, I would like a reviewer on SIRI as well as I am not familiar to how multi-modal station works there. |
Summary
Handle alerts for stations in GTFS-RT and the corresponding API
Issue
Fixes #6120
In particular, this should achieve the following from the GTFS GraphQL API:
Unit tests
Integration tests are added into the GTFS GraphQL API
Documentation
None
Changelog
Needed
Bumping the serialization version id
Not needed