Repository navigation
Update OsmTagMapper according to the default restrictions on OpenStreetMap Wiki - #6760
Merged
leonardehrenfried merged 16 commits intoAug 13, 2025
Merged
Conversation
miklcct
marked this pull request as ready for review
July 22, 2025 12:22
…king is allowed but discouraged on cycleways
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6760 +/- ##
==========================================
Coverage ? 71.86%
Complexity ? 19127
==========================================
Files ? 2074
Lines ? 77785
Branches ? 7937
==========================================
Hits ? 55904
Misses ? 19064
Partials ? 2817 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
I have made a commit to add walk safety for all highways in the default mapper. It sets a high value for most main roads but a low value if there is a pavement (sidewalk). P.S. I have reverted it. It breaks too many tests. I will not attempt to do anything on walk safety in this PR anymore and will do it in another PR. |
This reverts commit 5a20317.
optionsome
reviewed
Aug 5, 2025
optionsome
reviewed
Aug 5, 2025
optionsome
reviewed
Aug 5, 2025
optionsome
reviewed
Aug 5, 2025
…oot=yes or bicycle=yes (it happens in London)
optionsome
approved these changes
Aug 11, 2025
leonardehrenfried
approved these changes
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Instructions
Summary
Update OsmTagMapper with permissions according to the default values in the OpenStreetMap Wiki. In particular, I am testing that:
The country-specific restrictions are also updated accordingly.
In the future, we would like to unbundle the permission and safety handling, and add more extensive walk safety as well.
Issue
Closes #6758
Unit tests
Added for a variety of ways.
In addition, a mistake in the Houston test in a cycling tunnel is fixed.
Documentation
Changelog
Bumping the serialization version id
Yes. The permissions are changed.