Minor improvements in vertex to area linking - #6826
Conversation
…avadoc to explain
term multiplier is confusing and only used for areas
leonardehrenfried
left a comment
There was a problem hiding this comment.
Generally, I'm fine with this but would probably use a float everywhere.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6826 +/- ##
==========================================
Coverage 71.99% 72.00%
+ Complexity 19437 19426 -11
==========================================
Files 2100 2099 -1
Lines 78774 78729 -45
Branches 7963 7961 -2
==========================================
- Hits 56717 56686 -31
+ Misses 19249 19235 -14
Partials 2808 2808 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…reation New barrier processing duplicates vertices when parent entity changes
leonardehrenfried
left a comment
There was a problem hiding this comment.
There are probably a few more places where we could use floats instead of doubles when constructing the graph but that is beyond the scope of the PR.
|
I added one more somewhat related fix: walkable area builder passes the correct parent reference of each node when generating vertices. Previously part of the code used a common, randomly picked area group member. This did not have any effect because area group consists of entities at the same level. However, PR #6826 will introduce barrier logic which will get confused when node parent references are not consistent. |
|
It looks good now but give me a day or two to put this on our test bed to see if it still works well with the barrier PR. |
Summary
Unit tests
One unit test added to verify that area safety factors are considered
NOTE: The test is a bit flaky, apparently because of double to float conversion. Test values are chosen to avoid value drifting.
Documentation
Javadoc added to explain the no through logic.