Fix stop cancellation in case of repeated scheduled times - #6849
Merged
leonardehrenfried merged 2 commits intoSep 11, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6849 +/- ##
==========================================
Coverage 72.08% 72.08%
- Complexity 19517 19518 +1
==========================================
Files 2105 2105
Lines 78976 78977 +1
Branches 8007 8007
==========================================
+ Hits 56930 56931 +1
+ Misses 19228 19227 -1
- Partials 2818 2819 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
leonardehrenfried
force-pushed
the
skipped-repeated-times
branch
from
September 9, 2025 13:34
720fd71 to
ea3bd26
Compare
leonardehrenfried
force-pushed
the
skipped-repeated-times
branch
from
September 9, 2025 13:36
ea3bd26 to
48ff0a4
Compare
Contributor
|
Thanks. Can't see any problem with your approach as the scheduled diff is always 0 in this case for the cancelled stops, so the interpolated times are always the same as the previous non-cancelled stop. |
miklcct
approved these changes
Sep 10, 2025
leonardehrenfried
enabled auto-merge
September 10, 2025 11:34
optionsome
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It fixes a strange edge case where repeated times in the schedule lead to an inability to
SKIPstops with a GTFS-RT TripUpdate.Issue
Closes #6848
Unit tests
A module test was added.
Documentation
Javadoc.
cc @laurentg