Skip to content

Fix leaflet retina #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2020
Merged

Fix leaflet retina #168

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c79460
fix(base-map): remove detectRetina to prevent tiny map labels
landonreed May 28, 2020
177a56e
refactor(base-map): handle non-retina displays
landonreed May 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions lib/components/map/base-map.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,21 +298,29 @@ class BaseMap extends Component {
<LayersControl position='topright'>
{/* base layers */
baseLayers && baseLayers.map((layer, i) => {
// Fix tile size/zoom offset: https://stackoverflow.com/a/37043490/915811
const retinaProps = L.Browser.retina && layer.hasRetinaSupport
// If layer supports retina tiles, set tileSize and zoomOffset
// (see https://stackoverflow.com/a/37043490/915811).
// Otherwise, use detectRetina to request more tiles (scaled down):
// https://leafletjs.com/reference-1.6.0.html#tilelayer-detectretina
const retinaProps = layer.hasRetinaSupport
? { tileSize: 512, zoomOffset: -1 }
: {}
: { detectRetina: true }
// If Browser doesn't support retina, remove @2x from URL so that
// retina tiles are not requested.
const url = L.Browser.retina
? layer.url
: layer.url.replace('@2x', '')
return (
<LayersControl.BaseLayer
name={layer.name}
checked={i === 0}
key={i}>
<TileLayer
url={layer.url}
url={url}
attribution={layer.attribution}
maxZoom={layer.maxZoom}
{...retinaProps}
detectRetina />
/>
</LayersControl.BaseLayer>
)
})
Expand Down