Add trip editing commands to saved trips list #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evansiroky
approved these changes
Sep 16, 2020
Contributor
evansiroky
left a comment
evansiroky
left a comment
There was a problem hiding this comment.
Good to have this functionality for now. We can worry about the UX of it later.
landonreed
requested changes
Sep 24, 2020
landonreed
reviewed
Oct 7, 2020
landonreed
reviewed
Oct 7, 2020
landonreed
approved these changes
Oct 7, 2020
Member
landonreed
left a comment
landonreed
left a comment
There was a problem hiding this comment.
Looks good just a couple of conditions for approval.
Merged
Member
|
🎉 This PR is included in version 1.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes an incremental improvement to the monitored trip management flow
by adding the following trip commands for each trip in the saved trips list:
Placement and appearance of these buttons is up for discussion, let me know.