Further a11y fixes #434
Further a11y fixes #434
Conversation
There was a problem hiding this comment.
This looks good, just a couple of nits. Also, while we're at it, does it make sense to test all of the routes (I have started this in #436)? Also, it seems like we would want yarn a11y-test to run as part of the yarn test script (or at least include it in the GitHub workflow/CI)?
|
Got things working in #436 and left a comment. |
refactor: move routes to array for testing
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
I would recommend refining the a11y attributes related to the PatternRow expand/collapse button. Also should the routeDetails color applied to all links?
|
Thanks for the good suggestions Binh! Makes me think that a full a11y pass of non-mandatory fixes might be something to add to the backlog! |
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
Maybe one little tweak but otherwise good to go for me.
Co-authored-by: binh-dam-ibigroup <56846598+binh-dam-ibigroup@users.noreply.github.com>
miles-grant-ibigroup
assigned
binh-dam-ibigroup and
landonreed and unassigned
miles-grant-ibigroup and
binh-dam-ibigroup
|
Thanks Binh! Language is changed. Assigning to @landonreed for merge. |
|
🎉 This PR is included in version 3.4.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
The first round of a11y fixes failed to test trimet-mod-otp components or the stop viewer. This PR makes the remaining changes, and includes tests for the stop viewer. trimet-mod-otp isn't tested, as this would require adding the same puppeteer tests to that repo.