Route Viewer Search and Filter #435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
landonreed
requested changes
Aug 19, 2021
Collaborator
Author
|
Everything addressed! With the redux I did my best to follow project conventions, but am very open to restructuring things to match the rest of the project. Also I'd like to propose @binh-dam-ibigroup as the second reviewer as we're adding |
landonreed
reviewed
Aug 23, 2021
landonreed
reviewed
Aug 23, 2021
Collaborator
Okay, thanks for clarifying. |
binh-dam-ibigroup
approved these changes
Sep 14, 2021
Collaborator
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
Two more formatting things, but otherwise great work, thanks for the changes!
miles-grant-ibigroup
added
the
BLOCKED
Collaborator
Author
|
Thanks Binh! This is now blocked waiting for piggyback PR #441 to be merged |
miles-grant-ibigroup
assigned
binh-dam-ibigroup and
miles-grant-ibigroup and unassigned
miles-grant-ibigroup and
binh-dam-ibigroup
Route Viewer Details Pane and Realtime Vehicle Position Viewer
miles-grant-ibigroup
removed
the
BLOCKED
Contributor
|
🎉 This PR is included in version 3.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds search and filter capabilities to the route viewer. It also moves the route viewer to the Navbar to make it easier to find.