diff --git a/.github/workflows/codespell.yml b/.github/workflows/codespell.yml index c8ac9648c..ff497a107 100644 --- a/.github/workflows/codespell.yml +++ b/.github/workflows/codespell.yml @@ -12,4 +12,6 @@ jobs: - uses: codespell-project/actions-codespell@master with: check_filenames: true - skip: ./.git,yarn.lock + # The a11y test file has a false positive and the ignore list does not work + # see https://github.com/opentripplanner/otp-react-redux/pull/436/checks?check_run_id=3369380014 + skip: ./.git,yarn.lock,./a11y/a11y.test.js diff --git a/__tests__/components/viewers/__snapshots__/stop-viewer.js.snap b/__tests__/components/viewers/__snapshots__/stop-viewer.js.snap index 43bc5f765..81e21e621 100644 --- a/__tests__/components/viewers/__snapshots__/stop-viewer.js.snap +++ b/__tests__/components/viewers/__snapshots__/stop-viewer.js.snap @@ -827,12 +827,15 @@ exports[`components > viewers > stop viewer should render countdown times after >
20 @@ -842,6 +845,7 @@ exports[`components > viewers > stop viewer should render countdown times after
viewers > stop viewer should render countdown times after className="expansion-button-container" >
@@ -81,30 +89,36 @@ export default class PatternRow extends Component { {/* expanded view */} + leave={{ animation: 'slideUp' }} + > + {this.state.expanded && ( -
-
+
+
{/* trips table header row */} -
-
-
DEPARTURE
-
STATUS
+
+
+
DEPARTURE
+
STATUS
{/* list of upcoming trips */} - {hasStopTimes && ( + {hasStopTimes && sortedStopTimes.map((stopTime, i) => { const { departureDelay: delay, realtimeState } = stopTime return (
-
- To {stopTime.headsign} -
-
+ role='row' + style={{ + display: 'table-row', + fontSize: 14, + marginTop: 6 + }} + > +
To {stopTime.headsign}
+
-
+
) - }) - )} + })}
)} diff --git a/lib/components/viewers/realtime-status-label.js b/lib/components/viewers/realtime-status-label.js index e93cb092f..8525e62a2 100644 --- a/lib/components/viewers/realtime-status-label.js +++ b/lib/components/viewers/realtime-status-label.js @@ -67,7 +67,7 @@ const RealtimeStatusLabel = ({ const isEarlyOrLate = status === REALTIME_STATUS.EARLY || status === REALTIME_STATUS.LATE // Use a default background color if the status object doesn't set a color // (e.g. for 'Scheduled' status), but only in withBackground mode. - const color = STATUS[status].color || (withBackground && '#bbb') + const color = STATUS[status].color || (withBackground && '#6D6C6C') // Render time if provided. let renderedTime if (time) { diff --git a/lib/components/viewers/route-viewer.js b/lib/components/viewers/route-viewer.js index 66c74a7d8..95ad0cbd6 100644 --- a/lib/components/viewers/route-viewer.js +++ b/lib/components/viewers/route-viewer.js @@ -230,7 +230,7 @@ class RouteRow extends PureComponent { {isActive && ( {route.url - ? Route Details + ? Route Details : 'No route URL provided.' } diff --git a/lib/components/viewers/viewers.css b/lib/components/viewers/viewers.css index b4097dccd..fe92df858 100644 --- a/lib/components/viewers/viewers.css +++ b/lib/components/viewers/viewers.css @@ -26,6 +26,11 @@ animation-name: yellowfade; } +/* Route Details Link a11y compatibility */ +a.routeDetails { + color: #2370b3; +} + /* Remove arrows on date input */ .otp .stop-viewer-body input[type="date"]::-webkit-inner-spin-button { -webkit-appearance: none; diff --git a/package.json b/package.json index 87479045c..0e8451e3e 100644 --- a/package.json +++ b/package.json @@ -3,7 +3,7 @@ "description": "A library for writing modern OpenTripPlanner-compatible multimodal journey planning web applications using React and Redux", "main": "build/index.js", "scripts": { - "a11y-test": "mastarm test a11y --force-exit", + "a11y-test": "mastarm test a11y --runInBand --force-exit", "build": "mastarm build --env production", "cover": "mastarm test -e test --coverage", "jest": "mastarm test -e test __tests__",