Route Viewer Details Pane and Realtime Vehicle Position Viewer #441
Conversation
…etries in one request
miles-grant-ibigroup
changed the title
|
Have implemented all changes and slimmed down |
Can this be a fallback instead? |
|
Yes it can be! In 30f4a83 |
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
Some more recommendations for changes.
i18n/en-US.yml
Outdated
| incoming_at: "approaching {stop}" | ||
| stopped_at: "doors open at {stop}" | ||
| in_transit_to: "next stop {stop}" | ||
|
|
||
| travellingAt: "travelling at {milesPerHour}" | ||
| relativeTime: "{seconds} ago" |
There was a problem hiding this comment.
Any reason the first letter of the displayed text is not capitalized?
There was a problem hiding this comment.
Personal preference, but I do think it looks cleaner and helps hide the fact that 3 rows of text are being shown with no graphics to balance it out
| import React, { Component } from 'react' | ||
| import { connect } from 'react-redux' | ||
| import styled from 'styled-components' | ||
| import PropTypes from 'prop-types' |
There was a problem hiding this comment.
Sort imports. (I recall we enabled prettier automatically on commits at one point?)
|
Thanks for the comments Binh. All addressed |
miles-grant-ibigroup
assigned
miles-grant-ibigroup and
binh-dam-ibigroup and unassigned
binh-dam-ibigroup and
miles-grant-ibigroup
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
Good to go after fixing the typo and the import order.
|
Thanks Binh! All changes are addressed. |
miles-grant-ibigroup
assigned
binh-dam-ibigroup and
miles-grant-ibigroup and unassigned
miles-grant-ibigroup and
binh-dam-ibigroup
|
🎉 This PR is included in version 3.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Expands the route viewer details to be a full fledged view that can fill the sidebar.
Piggyback PR of #435 for internationalization.
New components added in this PR are still missing internationalization, but these will be added once #435 is approved.
Should work with existing OTP instances, but has features designed to work explicitly with ibi-group/OpenTripPlanner#63. If not using the new version of OTP, route shapes will not appear (due to changed OTP endpoints) and realtime vehicles will not appear