Traveler tools menu #443

robertgregg3 · 2021-08-27T20:23:40Z

Blocked by #435 which provides internationalization for the app menu.

Refactored the current menu located in app-menu.js into it's own component with the following uses:

Allow sub menus
Allow sub menus within submenus
optional icons from url or types
hyperlink option

Points to note:

The code uses the same setup as the patternRow.js expandable mechanics.
The menu is currently set up to go 2 sub menus deep: Top level > sub menu > sub menu
The additional menu items will sit below the standard menu items
The associated PR for the config repo can be found here

WIP notes:

I added the css to the index.css file which I can put into it's own file.
The hyperlinks for ATL RIDES are not in place and need to be added
The icons are just a first draft, mostly hyperlinks. Would need a review for sure
Any other improvements or things I have done wrong in the code etc I would be happy to hear

…able

On Desktop, pressing the hamburger menu on the top left opens a sliding pane which contains the new app menu. The app menu n ow includes a 'Traveler Tools' menu. This is done by creating a custom MenuItem component.

…ss the additional menu items

…menu structure

robertgregg3 · 2021-08-27T20:31:25Z

Have just seen that the tests have failed. Will take a look when I am back on Tuesday 31st August

miles-grant-ibigroup

Foundation is solid, just a few small polishing changes! I think the biggest thing is adjusting the spacing between items and text positions to establish a clear hierarchy of items and make it clearer where submenus begin and end! If you'd me to make some mockups to better explain what I mean please let me know.

lib/components/app/app-menu.js

lib/index.css

lib/components/app/menu-item.js

lib/components/app/app-menu.js

…ructure

robertgregg3 · 2021-09-09T17:25:02Z

It is failing on a test from the stop-viewer.js file which I think must be there because of the recent changes you did @binh-dam-ibigroup to the linting etc? I did not touch that file with this PR.

miles-grant-ibigroup

Really coming along! I'm loving the look (just a small personal opinion about padding). Just a few small cleanup suggestions.

lib/components/app/app-menu.js

lib/index.css

package.json

miles-grant-ibigroup · 2021-09-21T16:30:57Z

Thanks @binh-dam-ibigroup for the localization PR! Everything is merged and working. I am going to finish localizing this PR tomorrow morning and then will assign it back to you.

binh-dam-ibigroup

A few minor changes needed to close some gaps and it will be good to go.

example-config.yml

i18n/en-US.yml

lib/components/app/app-menu.js

miles-grant-ibigroup · 2021-09-27T08:37:03Z

Good catches, thanks!

binh-dam-ibigroup

One tiny last change, but this looks good!

lib/components/app/app-menu.js

philip-cline

Fixed one tiny typo, everything else looks good to me

github-actions · 2021-10-05T17:07:44Z

🎉 This PR is included in version 3.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Robert Gregg added 6 commits August 20, 2021 14:55

refactor(package.json): Added React Sidebar Pro

d30b5c5

refactor(app-menu.js):

68cff74

refactor(app-menu.js): Draft menu to see if React Sidebar pro is suit…

4b88064

…able

feat(app-menu.js): Added Traveler Tools Menu

0acabea

On Desktop, pressing the hamburger menu on the top left opens a sliding pane which contains the new app menu. The app menu n ow includes a 'Traveler Tools' menu. This is done by creating a custom MenuItem component.

refactor(app-menu.js): Refactored to use the config.yaml file to acce…

c6819f6

…ss the additional menu items

docs(example-config.yml): Added some data to show the additional app …

9ac939d

…menu structure

robertgregg3 requested review from binh-dam-ibigroup, landonreed and miles-grant-ibigroup August 27, 2021 20:23

miles-grant-ibigroup self-assigned this Aug 30, 2021

miles-grant-ibigroup requested changes Aug 30, 2021

View reviewed changes

miles-grant-ibigroup assigned robertgregg3 and unassigned miles-grant-ibigroup Aug 30, 2021

Robert Gregg added 2 commits August 31, 2021 15:37

refactor(app-menu.js): Added PR feedback items

941f7df

refactor(app-menu,js): Refactored the UI structure and confog.yaml st…

b40235f

…ructure

robertgregg3 requested review from miles-grant-ibigroup and removed request for landonreed September 9, 2021 17:13

robertgregg3 assigned binh-dam-ibigroup and miles-grant-ibigroup and unassigned robertgregg3 Sep 9, 2021

miles-grant-ibigroup requested changes Sep 10, 2021

View reviewed changes

miles-grant-ibigroup assigned robertgregg3 and unassigned binh-dam-ibigroup and miles-grant-ibigroup Sep 10, 2021

miles-grant-ibigroup reviewed Sep 10, 2021

View reviewed changes

package.json Outdated Show resolved Hide resolved

refactor(app-menu.js): Refactored based on PR feedback

21f7fa2

robertgregg3 requested a review from miles-grant-ibigroup September 10, 2021 15:16

robertgregg3 removed their assignment Sep 10, 2021

miles-grant-ibigroup added 2 commits September 22, 2021 12:27

refactor(i18n/en-US): undo merge side effect string removal

4fa6bff

improvement(app-menu): localize component

5c5b58d

miles-grant-ibigroup removed their request for review September 22, 2021 11:45

miles-grant-ibigroup assigned binh-dam-ibigroup and unassigned miles-grant-ibigroup Sep 22, 2021

binh-dam-ibigroup requested changes Sep 24, 2021

View reviewed changes

example-config.yml Outdated Show resolved Hide resolved

i18n/en-US.yml Show resolved Hide resolved

lib/components/app/app-menu.js Outdated Show resolved Hide resolved

binh-dam-ibigroup assigned miles-grant-ibigroup and unassigned binh-dam-ibigroup Sep 24, 2021

binh-dam-ibigroup and others added 2 commits September 24, 2021 10:43

chore(i18n): Match FR file with latest updates.

561e844

refactor: address pr comments

da3a686

miles-grant-ibigroup assigned binh-dam-ibigroup and unassigned miles-grant-ibigroup Sep 27, 2021

binh-dam-ibigroup approved these changes Sep 27, 2021

View reviewed changes

lib/components/app/app-menu.js Outdated Show resolved Hide resolved

binh-dam-ibigroup assigned miles-grant-ibigroup and unassigned binh-dam-ibigroup Sep 27, 2021

refactor(app-menu): use react-intl hook in functional component

cf487ff

miles-grant-ibigroup assigned philip-cline and unassigned miles-grant-ibigroup Sep 27, 2021

binh-dam-ibigroup mentioned this pull request Sep 30, 2021

Add Accessibility Labels to Legs and Itineraries #456

Merged

style(example-config): Fix tiny typo

3cad391

philip-cline approved these changes Oct 4, 2021

View reviewed changes

philip-cline assigned miles-grant-ibigroup and unassigned philip-cline Oct 4, 2021

miles-grant-ibigroup merged commit 60078f5 into dev Oct 4, 2021

miles-grant-ibigroup deleted the traveler-tools-menu branch October 4, 2021 15:27

miles-grant-ibigroup mentioned this pull request Oct 5, 2021

Release: October 5, 2021 #463

Merged

github-actions bot added the released label Oct 5, 2021

Traveler tools menu #443

Traveler tools menu #443

Uh oh!

Conversation

robertgregg3 commented Aug 27, 2021 • edited by miles-grant-ibigroup Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Points to note:

WIP notes:

Uh oh!

robertgregg3 commented Aug 27, 2021

Uh oh!

miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

robertgregg3 commented Sep 9, 2021

Uh oh!

miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

miles-grant-ibigroup commented Sep 21, 2021

Uh oh!

binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

miles-grant-ibigroup commented Sep 27, 2021

Uh oh!

binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

philip-cline left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 5, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

robertgregg3 commented Aug 27, 2021 •

edited by miles-grant-ibigroup

Loading