Retire trimet-mod-otp + Migrate from Mastarm to Craco #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New Release (v1): otp-ui Refactor and User Sign Up
Bug fix release
Next release
…release Release: Accessibility, Itinerary Body Time Format (and add saved trips)
Release - Hide the Save Trip Button if no user is logged in.
Release request
Next release
Next release
Next release
Patch release
Bug fix/feature release
Bug fix release
Big fix release
Next release
Patch release
Merge TravisCI replacement with GitHub Actions to master
Feature release
Feature release
Next release
Next release
Release (2021-07)
Release (2021-07 #2)
Release (2021-07 #3)
Feature Release: July 14, 2021
Patch release July 22 2021
Release: 17 August 2021
Release: 19 August 2021
miles-grant-ibigroup
added
BLOCKED
Collaborator
Author
|
With the flex PR merged, this PR is now ready to go! @philip-cline |
Collaborator
Author
|
I've disabled eslint on some difficult-to-type files. These files should definitely be typed as soon as possible, but I don't think it's a good idea to do so in this PR as it would result in expanding an already very large PR. |
philip-cline
approved these changes
Nov 29, 2021
Contributor
|
🎉 This PR is included in version 3.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR retires trimet-mod-otp, integrating its functionality into otp-rr.
This PR also adds typescript to files which the new linting rules request it to have.
Blocked waiting for flex PR #470 being merged into dev.
Closes #468
Issues to resolve:
Notes for reviewer
Until opentripplanner/otp-ui#295 is merged, the location field will continue to not work. The main aspects to test are if everything works as expected using all possible configs, and most crucially that the call taker and field trip still work as expected.
I would also like some feedback as to whether to squash some of these commits, as the PR brings quite a few commits.
Finally,
trimet-mod-otpran the trimet config out of the box. Should we ship this config with otp-rr now? At the moment, otp-rr does NOT work "out of the box", whereastrimet-mod-otpdid.