Update itinerary packages #599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philip-cline
approved these changes
May 4, 2022
miles-grant-ibigroup
approved these changes
May 4, 2022
Collaborator
miles-grant-ibigroup
left a comment
miles-grant-ibigroup
left a comment
There was a problem hiding this comment.
Other than a potential bug regression this looks good and seems to work! Thanks for getting things set up
lib/actions/form.js
Outdated
| return function (dispatch, getState) { | ||
| const state = getState() | ||
| if (state.otp.ui.mainPanelContent !== null) return state | ||
| if (state.otp.ui.mainPanelContent) return state |
Collaborator
There was a problem hiding this comment.
I'm not sure about this -- I think I remember there being a bug where this is sometimes explicitly set to undefined which causes strange behavior
Collaborator
Author
There was a problem hiding this comment.
Ok, I brought the !== null back in 145f814, the better way to handle it is to initialize state.otp.ui.mainPanelContent to null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates itinerary packages to use internationalization features.
Also fixes #597.
Note that
timeOptionsprops have been dropped, and I think, wheretimeOptions.offsetwas used, the applicable DST offset is already applied by the<FormattedTime>component.