Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: follow 4.2.0 upgrade #64

Open
andelf opened this issue Apr 6, 2021 · 3 comments
Open

TODO: follow 4.2.0 upgrade #64

andelf opened this issue Apr 6, 2021 · 3 comments

Comments

@andelf
Copy link
Contributor

andelf commented Apr 6, 2021

  • TIP 250: merkle tree root of transaction result
    • This might be a dangerous decision. since there're only 2 fields in transaction result are used.
  • Vote for tron power upgrade?
@oikos1
Copy link
Contributor

oikos1 commented Apr 7, 2021

By reading https://github.com/tronprotocol/tips/blob/master/tip-250.md, it seems currently the Tron protocol lacks tampering protection in the block finalization. How would using only 2 fields of the transaction result represent a risk?

@andelf
Copy link
Contributor Author

andelf commented Apr 24, 2021

The only 2 fields are ret and contract_ret. They and are checked by block's merkle_tree_root, (hash against all txns in the block).

There once was an account_state_root field in Block, which is abandoned.

@andelf
Copy link
Contributor Author

andelf commented Apr 24, 2021

See-also: tronprotocol/java-tron#3753

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants