Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[X9D] GPS coordinates are sometimes badly displayed #4631

Closed
bsongis opened this issue Mar 17, 2017 · 17 comments

Comments

Projects
None yet
4 participants
@bsongis
Copy link
Member

commented Mar 17, 2017

img_5949

@bsongis bsongis added this to the OpenTX 2.2.0 milestone Mar 17, 2017

@sirPerna

This comment has been minimized.

Copy link
Contributor

commented Mar 17, 2017

only values <1.0 affected.

@3djc 3djc self-assigned this Mar 17, 2017

@3djc

This comment has been minimized.

Copy link
Contributor

commented Mar 17, 2017

With the coordinates taken from the fpv screenshot (50.80521, -0.43619) (I'm assuming the scrrenshot shows long first, since the other way around puts you well at sea near somalia)
N364 DMS:
image

N364 NMEA
image

@3djc 3djc closed this Mar 18, 2017

@sirPerna

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2017

@3djc Did you fix anything becase it's still not working here. The CRSF sends Latitude first.

image

@3djc

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2017

What version are you using ?

@sirPerna

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2017

2.2.0N364 the latest it downloaded yesterday.

@kilrah

This comment has been minimized.

Copy link
Member

commented Mar 18, 2017

Well we didn't even know you were using CRSF telemetry... We thus checked with FrSky obviously.

@sirPerna

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2017

Sorry for the bad report in this case. Setup is TBS CORE PRO - Crossfire - Taranis. I can share a test firmware for Crossfire so no additional hardware required then a Crossfire TX and a OpenTX remote.

@3djc

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2017

If I input your values with 364, i get the screens above (mine) that are correct.
If I used N362, I get your screen :
image

Can you confirm on the radio you are running N364, because it doesn't look like it

@kilrah

This comment has been minimized.

Copy link
Member

commented Mar 18, 2017

2.2.0N364 the latest it downloaded yesterday.

Then you probably downloaded companion N364, but didn't download / flash N364 firmware.

@bsongis

This comment has been minimized.

Copy link
Member Author

commented Mar 18, 2017

@sirPerna would you tell us which firmware version you see in the VERSION screen on the radio?

@sirPerna

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2017

2017-03-18 09 41 27

@bsongis

This comment has been minimized.

Copy link
Member Author

commented Mar 18, 2017

ok, we have a bug for sure

@bsongis

This comment has been minimized.

Copy link
Member Author

commented Mar 18, 2017

bug confirmed even in our current 'next' branch

@bsongis

This comment has been minimized.

Copy link
Member Author

commented Mar 18, 2017

the GPS parsing code is here:
https://github.com/opentx/opentx/blob/next/radio/src/telemetry/crossfire.cpp

if (getCrossfireTelemetryValue<4>(3, value))
        processCrossfireTelemetryValue(GPS_LATITUDE_INDEX, value/10);
@bsongis

This comment has been minimized.

Copy link
Member Author

commented Mar 18, 2017

it returns an uint32_t which is not good here, at least the / 10 division cannot be done this way

@bsongis bsongis self-assigned this Mar 18, 2017

@bsongis

This comment has been minimized.

Copy link
Member Author

commented Mar 18, 2017

@3djc I take it, testing in progress with @sirPerna

bsongis added a commit that referenced this issue Mar 18, 2017

Fixes #4631
Tested by @sirPerma

bsongis added a commit that referenced this issue Mar 18, 2017

@sirPerna

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2017

Tested. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.