Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Radio] Adjust value limits for mix sources and update UI for LSs, CFs & telem. #5445

Merged
merged 3 commits into from Dec 19, 2017

Conversation

@mpaperno
Copy link
Member

commented Nov 30, 2017

Adjust some value limits for mix sources and update editing UI for LSs, CFs, & telem. bars:

  • Increase timer limits to +/-8:59:59 when used with LSs, CFs, & bars;
  • Increase Lua script output limits to +/-30K (see #3581);
  • Trim limits based on extended limit model setting;
  • Limit TX voltage to 25.5;
  • Limit TX time comparison value to 29:59m;
  • Use proper GVar limits (user-configured), display precision, & unit in LSs & telem. bars;
  • Display timer values properly with hours (instead of mmm:ss);
  • getTimerString() would fail with times >= 100min if hours weren't shown.

Fixes #3581 (fw part)

This PR relates to #5437 and should be merged together.

Notes/discuss:

Negative times always blink, even in the editor screens. Obviously distracting especially when it's selected for editing. I'd vote for changing this, but somehow keep the old default of blinking when timer is not used on editing screen.

I think the X7 (small ARM screen) time display function could be revisited. When viewing values >=60m it goes into a "HHhMM" display mode where seconds can't be seen (but are still changed when editing). I understand the problem with space, but at least in the editor screens I think the full h:mm:ss format would fit just about everywhere (there's no place 2-digit hours are shown). One possible exception is the CF editor where we don't yet have a dedicated "pop up" dialog to edit the values. @3djc ?

mpaperno added 3 commits Nov 30, 2017
[firmware][ARM] Adjust some value limits for mix sources and update e…
…diting UI for LSs, CFs, & telem. bars:

    * Increase timer limits to +/-8:59:59 when used with LSs, CFs, & bars;
    * Increase Lua script output limits to +/-30K;
    * Trim limits based on extended limit model setting;
    * Limit TX voltage to 25.5;
    * Limit TX time comparison value to 29:59m;
    * Use proper GVar limits (user-configured), display precision, & unit in LSs & telem. bars;
    * Display timer values properly with hours (instead of mmm:ss).
@bsongis

This comment has been minimized.

Copy link
Member

commented Nov 30, 2017

Wondering if you tested this PR on the good old 9X? Even on the simu. Does it increase flash usage on 9X?

@bsongis bsongis added this to the OpenTX 2.2.2 milestone Nov 30, 2017

@mpaperno

This comment has been minimized.

Copy link
Member Author

commented Nov 30, 2017

Yessir I did indeed. No functional change on any AVR platforms. No memory usage changes.

9X build with many options enabled (gvars, frsky, etc), current 2.2:

AVR Memory Usage
----------------
Device: atmega64

Program:   64730 bytes (98.8% Full)
(.text + .data + .bootloader)

Data:       3227 bytes (78.8% Full)
(.data + .bss + .noinit)

With this PR:


AVR Memory Usage
----------------
Device: atmega64

Program:   64730 bytes (98.8% Full)
(.text + .data + .bootloader)

Data:       3227 bytes (78.8% Full)
(.data + .bss + .noinit)
@bsongis

This comment has been minimized.

Copy link
Member

commented Dec 1, 2017

Cool! I need to have a closer look to it then. I propose we don't include it in 2.2.1

@bsongis bsongis merged commit b69f36a into 2.2 Dec 19, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bsongis bsongis deleted the mpaperno/fw_src_limits branch Dec 19, 2017

mr-pokryshkin added a commit to mr-pokryshkin/opentx that referenced this pull request Dec 19, 2017
[Radio] Adjust value limits for mix sources and update UI for LSs, CF…
…s & telem. (opentx#5445)

* [firmware][ARM] Adjust some value limits for mix sources and update editing UI for LSs, CFs, & telem. bars:
    * Increase timer limits to +/-8:59:59 when used with LSs, CFs, & bars;
    * Increase Lua script output limits to +/-30K;
    * Trim limits based on extended limit model setting;
    * Limit TX voltage to 25.5;
    * Limit TX time comparison value to 29:59m;
    * Use proper GVar limits (user-configured), display precision, & unit in LSs & telem. bars;
    * Display timer values properly with hours (instead of mmm:ss).

* [firmware] getTimerString() would fail with times >= 100min if hours weren't shown.

* Fix builds w/out GVars.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.