New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Companion] Log viewer Google Earth fixes #5937

Merged
merged 2 commits into from Jun 3, 2018

Conversation

Projects
None yet
2 participants
@mpaperno
Copy link
Member

mpaperno commented Jun 2, 2018

  • Use relative path for Google Earth track icon (fixes #5080);
  • Use detached process to launch GE (does not restart GE for every export, does not keep handle to GE process (Qt docs));
  • Fix typo in warning message;
  • Fix auto-connection warning from Qt due to misnamed function.
[Companion][LogsDialog] Use relative path for Google Earth track icon (
…fixes #5080); Use detached process to launch GE (does not restart GE for every export, does not keep handle to GE process); Fix typo in warning message.

@mpaperno mpaperno added the Companion label Jun 2, 2018

[LogsDialog] Use GE export file path as base for icon path (don't ass…
…ume TempDir); Fix auto-connection warning from Qt due to misnamed function; Remove redundant check for existing GE file.

@bsongis bsongis merged commit 9796654 into 2.2 Jun 3, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bsongis bsongis deleted the mpaperno/cpn_ge_export branch Jun 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment