[popup] Should `showPopup()` and `hidePopup()` throw?

[mfreed7]

I think this is mostly an ergonomics question. But what should happen here?

<div>Not a popup</div>
<div popup=popup>Valid popup</div>

<script>
const nonPopup = document.querySelector(':not([popup])');
const popup = document.querySelector('[popup]');
nonPopup.showPopup(); // Exception? Console warning? Nothing?
nonPopup.hidePopup(); // Same questions
popup.hidePopup(); // What about here? The popup isn't showing yet.

Thoughts?

[mfreed7]

So we just had a discussion at OpenUI, and somehow the minutes didn't get posted. Here is a copy/paste from the IRC.

The Open UI Community Group just discussed 511, and agreed to the following:

• RESOLVED: the 'showPopup' and 'hidePopup' methods should throw in invalid situations.

The full IRC log of that discussion

[11:06]  masonf: #511 we move the popup to an element meaning it can apply to anything. There's 2 JS APIs showPopup and Hidepopup
[11:07]  present+
[11:07]  q+
[11:07] * Zakim sees JonathanNeal on the speaker queue
[11:08]  masonf: If we remove the attribute of a showing popup, it will be hidden
[11:09]  if you did .showModal() on an element that isn't a dialog, you get an "Uncaught TypeError" / .showModal is not a function
[11:09]  emilio: I vote for throwing, specially if they are developer errors
[11:09]  JonathanNeal: Are there prior examples of methods in the DOM which are similar to the popup methods that have made these decisions before
[11:10] == davatron5000 [~davatron5000@7df9ea9e.public.cloak] has joined #openui
[11:10]  present+
[11:11]  I would lean on throwing, too, based on bkardell_’s reference.
[11:11]  ack JonathanNeal
[11:11] * Zakim sees no one on the speaker queue
[11:11]  brian: The only thing I can think of is detached shadows
[11:11]  Proposed resolution: the 'showPopup' and 'hidePopup' methods should throw in invalid situations.
[11:11]  s/detached shadows/attachShadow
[11:11]  Jonathan: Mason will you be seeking a resolution to have this throw?
[11:11]  +1 to throwing errors
[11:11]  +1 to this. I agree with `attachShadow` being a good example to follow.
[11:12]  +1
[11:12]  Jonathan: We have a resolution that showPopup and hidePopup should throw in invalid situations
[11:12]  RESOLVED: the 'showPopup' and 'hidePopup' methods should throw in invalid situations.

[mfreed7]

Based on the resolution above, I'm going to close this issue as resolved.