Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define file input anatomy #91

Closed
gregwhitworth opened this issue May 20, 2020 · 4 comments
Closed

Define file input anatomy #91

gregwhitworth opened this issue May 20, 2020 · 4 comments
Labels
file Issue or PR related to the file component needs edits This is ready for edits to be made research This is for any issue that is related to open-ui research work stale

Comments

@gregwhitworth
Copy link
Member

There was a request for this to the CSSWG here: w3c/csswg-drafts#5049

They are currently focused on the psuedo element for button but it would be good to have a full anatomy breakdown on a proposal page backed by our research.

@gregwhitworth gregwhitworth added the research This is for any issue that is related to open-ui research work label May 20, 2020
@gregwhitworth
Copy link
Member Author

In the PR I added the following:

Looking through the different parts across the different component libraries:

  • File Picker
  • File Selector

I think both of these are better than chooser but I do think all of them should be appended with button. @Roy-Orbison then made the valid point regarding other standards referencing this control:

The majority of standards documents for HTML and JavaScript refer to such controls as file upload, and the action performed as selection, and have done so for many years. What benefit is there to CSS authors in deviating from those conventions?

Because of this I'd like to recommend that we use file-selector-button. Thoughts?

@gregwhitworth gregwhitworth added the agenda+ Use this label if you'd like the topic to be added to the meeting agenda label Jun 1, 2020
@gregwhitworth gregwhitworth linked a pull request Jun 1, 2020 that will close this issue
@gregwhitworth
Copy link
Member Author

We discussed this in today's telecon, the minutes are here.
Here is the resolution:

RESOLUTION: Use the name file-selector-button for the file input button part

@mfreed7 had a good point that we should ensure that this naming aligns with the anatomy we're actively investigating for <select>.

@gregwhitworth gregwhitworth added needs edits This is ready for edits to be made and removed agenda+ Use this label if you'd like the topic to be added to the meeting agenda labels Jun 4, 2020
@gregwhitworth gregwhitworth added the file Issue or PR related to the file component label Dec 3, 2020
@github-actions
Copy link

There hasn't been any discussion on this issue for a while, so we're marking it as stale. If you choose to kick off the discussion again, we'll remove the 'stale' label.

@github-actions github-actions bot added the stale label Mar 20, 2022
@andrico1234
Copy link
Collaborator

Closing this as the File proposal has been added to the Open UI site

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
file Issue or PR related to the file component needs edits This is ready for edits to be made research This is for any issue that is related to open-ui research work stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants