Charger Related fixes for v2 server protocol and Nissan Leaf #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this conflict with the work Michael / me have done recently. Can you review it, and see if it is still required? |
|
Micheal and your work has superseded this minimal implementation with a much more complete implementation in server_v2. I've integrated the leaf changes into a new pull request forthcoming. Closing. |
dexterbg
pushed a commit
that referenced
this pull request
Dec 3, 2017
dexterbg
pushed a commit
that referenced
this pull request
Jan 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've done a minimal implementation of the charger related states based on the main ms_v_charge_inprogress metric. The leaf doesn't use any of the sub-states so I haven't tried to implement them as I'm not sure what they do (sorry).