Add shortened common onvif namespace prefixes#54
Conversation
This fixes some Tapo cameras that respond with a 500 error when receiving the ns0/ns1 namespace prefix with embedded xmlns definitions inside each element. A similar change was done upstream here: FalkTannhaeuser/python-onvif-zeep#46 for mvantellingen/python-zeep#870. I also updated the events example that was broken.
|
I can take a look the week after Thanksgiving |
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
|
Tested with a few random ONVIF cameras and didn't observe any regressions |
|
Thanks, Nick! |
|
3.1.13 published |
|
I didn't do a dep update PR to home-assistant/core as I ran out of time getting after getting the CI/codecov/publishing working on this repo. If someone could do that, it would be appreciated. |
|
I'm going to update home-assistant/core#130769 to include the version bump. |
|
Please follow HA best practices and do a separate PR for the version bump |
|
Okay, will leave it alone then and submit a separate PR |
|
Example of previous dep bumps for various integrations https://github.com/home-assistant/core/pulls?q=sort%3Aupdated-desc+is%3Apr+label%3Adependency+is%3Aclosed |
This fixes some Tapo cameras that respond with a 500 error when receiving the ns0/ns1 namespace prefix with embedded xmlns definitions inside each element.
A similar change was done upstream here:
FalkTannhaeuser/python-onvif-zeep#46
for mvantellingen/python-zeep#870.
This fixes the main barrier for getting JurajNyiri/HomeAssistant-Tapo-Control#304 fixed.
I also updated the events example that was broken.