Skip to content

Add shortened common onvif namespace prefixes#54

Merged
bdraco merged 9 commits into
openvideolibs:asyncfrom
jterrace:tapo-500
Dec 3, 2024
Merged

Add shortened common onvif namespace prefixes#54
bdraco merged 9 commits into
openvideolibs:asyncfrom
jterrace:tapo-500

Conversation

@jterrace

Copy link
Copy Markdown

This fixes some Tapo cameras that respond with a 500 error when receiving the ns0/ns1 namespace prefix with embedded xmlns definitions inside each element.

A similar change was done upstream here:
FalkTannhaeuser/python-onvif-zeep#46

for mvantellingen/python-zeep#870.

This fixes the main barrier for getting JurajNyiri/HomeAssistant-Tapo-Control#304 fixed.

I also updated the events example that was broken.

This fixes some Tapo cameras that respond with a 500 error when
receiving the ns0/ns1 namespace prefix with embedded xmlns definitions
inside each element.

A similar change was done upstream here:
FalkTannhaeuser/python-onvif-zeep#46

for mvantellingen/python-zeep#870.

I also updated the events example that was broken.
@bdraco

bdraco commented Nov 22, 2024

Copy link
Copy Markdown
Member

I can take a look the week after Thanksgiving

Comment thread requirements.txt Outdated
@bdraco bdraco changed the title Add shortened common onvif namespace prefixes. Add shortened common onvif namespace prefixes Dec 3, 2024
@codecov

codecov Bot commented Dec 3, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
onvif/client.py 53.62% <100.00%> (+0.54%) ⬆️

@bdraco bdraco merged commit 3a06809 into openvideolibs:async Dec 3, 2024
@bdraco

bdraco commented Dec 3, 2024

Copy link
Copy Markdown
Member

Tested with a few random ONVIF cameras and didn't observe any regressions

@jterrace

jterrace commented Dec 3, 2024

Copy link
Copy Markdown
Author

Thanks, Nick!

@bdraco

bdraco commented Dec 3, 2024

Copy link
Copy Markdown
Member

3.1.13 published

@bdraco

bdraco commented Dec 3, 2024

Copy link
Copy Markdown
Member

I didn't do a dep update PR to home-assistant/core as I ran out of time getting after getting the CI/codecov/publishing working on this repo. If someone could do that, it would be appreciated.

@jterrace

jterrace commented Dec 3, 2024

Copy link
Copy Markdown
Author

I'm going to update home-assistant/core#130769 to include the version bump.

@bdraco

bdraco commented Dec 3, 2024

Copy link
Copy Markdown
Member

@jterrace

jterrace commented Dec 3, 2024

Copy link
Copy Markdown
Author

Okay, will leave it alone then and submit a separate PR

@jterrace jterrace deleted the tapo-500 branch December 4, 2024 01:46
@bdraco

bdraco commented Dec 4, 2024

Copy link
Copy Markdown
Member

Example of previous dep bumps for various integrations https://github.com/home-assistant/core/pulls?q=sort%3Aupdated-desc+is%3Apr+label%3Adependency+is%3Aclosed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants