Skip to content

Commit

Permalink
dpdk: Deprecate vhost-user dequeue zero-copy.
Browse files Browse the repository at this point in the history
Dequeue zero-copy is no longer supported for vhost-user client mode
in DPDK due to commit [1].

In addition to this, zero-copy mode has been proposed to be marked
deprecated in [2] with removal in the next DPDK LTS release.

This commit deprecates support for vhost-user dequeue zero-copy in OVS
with its removal expected in the next OVS release.

[1] 715070ea10e6 ("vhost: prevent zero-copy with incompatible client
    mode")
[2] http://mails.dpdk.org/archives/dev/2020-August/177236.html

Signed-off-by: Ian Stokes <ian.stokes@intel.com>
Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Acked-by: Ilya Maximets <i.maximets@ovn.org>
  • Loading branch information
istokes committed Aug 12, 2020
1 parent 36a9a77 commit 5910c2e
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 0 deletions.
5 changes: 5 additions & 0 deletions Documentation/topics/dpdk/vhost-user.rst
Expand Up @@ -556,6 +556,11 @@ shown with::
vhost-user Dequeue Zero Copy (experimental)
-------------------------------------------

.. warning::

vhost-user Dequeue Zero Copy is deprecated in OVS and will be removed in
the next release.

Normally when dequeuing a packet from a vHost User device, a memcpy operation
must be used to copy that packet from guest address space to host address
space. This memcpy can be removed by enabling dequeue zero-copy like so::
Expand Down
2 changes: 2 additions & 0 deletions NEWS
Expand Up @@ -18,6 +18,8 @@ v2.14.0 - xx xxx xxxx
CVE-2020-10726, this DPDK version is strongly recommended to be used.
* New 'ovs-appctl dpdk/log-list' and 'ovs-appctl dpdk/log-set' commands
to list and change log levels in DPDK components.
* Vhost-user Dequeue zero-copy support is deprecated and will be removed
in the next release.
- Linux datapath:
* Support for kernel versions up to 5.5.x.
- AF_XDP:
Expand Down
2 changes: 2 additions & 0 deletions lib/netdev-dpdk.c
Expand Up @@ -5085,6 +5085,8 @@ netdev_dpdk_vhost_client_reconfigure(struct netdev *netdev)
dev->up.name, dev->vhost_id);
if (zc_enabled) {
VLOG_INFO("Zero copy enabled for vHost port %s", dev->up.name);
VLOG_WARN("Zero copy support is deprecated and will be "
"removed in the next OVS release.");
}
}

Expand Down

0 comments on commit 5910c2e

Please sign in to comment.