Skip to content

Commit

Permalink
ovs-save: Don't always include the default flow during restore
Browse files Browse the repository at this point in the history
Currently the default flow (actions=NORMAL) is present in the flow table after
the flow table is restored also when the default flow is removed.

This commit changes the behaviour of the "ovs-save save-flows" command to use
"replace-flows" instead of "add-flows" to restore the flows. This is needed in
order to always have the new flow table as it was before restoring it.

Reported-by: Flavio Leitner <fbl@sysclose.org>
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1626096
Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
Acked-by: Flavio Leitner <fbl@sysclose.org>
Signed-off-by: Gurucharan Shetty <guru@ovn.org>
  • Loading branch information
drizzt authored and shettyg committed Sep 13, 2018
1 parent 9dc7456 commit f3a63fd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion utilities/ovs-save
Expand Up @@ -121,7 +121,7 @@ save_flows () {
cnt++;printf "{class="$1",type="$2",len="$3"}->"$4}'
echo "'"

printf "%s" "ovs-ofctl -O $ofp_version add-flows ${bridge} " \
printf "%s" "ovs-ofctl -O $ofp_version replace-flows ${bridge} " \
"\"$workdir/$bridge.flows.dump\""

# If possible, use OpenFlow 1.4 atomic bundle transaction to add flows
Expand Down

0 comments on commit f3a63fd

Please sign in to comment.