From b28902c18589ef7ed25b8b9d827c48bd693cc9b7 Mon Sep 17 00:00:00 2001 From: Timo Glastra Date: Thu, 28 Dec 2023 16:51:26 +0700 Subject: [PATCH] chore: add meta to rxjs timeout errors (#1683) Signed-off-by: Timo Glastra --- .../src/modules/connections/services/ConnectionService.ts | 5 ++++- .../src/modules/discover-features/DiscoverFeaturesApi.ts | 5 ++++- packages/core/src/modules/oob/OutOfBandApi.ts | 5 ++++- packages/core/src/modules/routing/MediationRecipientApi.ts | 5 ++++- .../modules/routing/services/MediationRecipientService.ts | 5 ++++- 5 files changed, 20 insertions(+), 5 deletions(-) diff --git a/packages/core/src/modules/connections/services/ConnectionService.ts b/packages/core/src/modules/connections/services/ConnectionService.ts index 05ec71bc77..b87c4f6a33 100644 --- a/packages/core/src/modules/connections/services/ConnectionService.ts +++ b/packages/core/src/modules/connections/services/ConnectionService.ts @@ -898,7 +898,10 @@ export class ConnectionService { filterContextCorrelationId(agentContext.contextCorrelationId), map((e) => e.payload.connectionRecord), first(isConnected), // Do not wait for longer than specified timeout - timeout(timeoutMs) + timeout({ + first: timeoutMs, + meta: 'ConnectionService.returnWhenIsConnected', + }) ) .subscribe(subject) diff --git a/packages/core/src/modules/discover-features/DiscoverFeaturesApi.ts b/packages/core/src/modules/discover-features/DiscoverFeaturesApi.ts index 3d074f9d18..2ab4550b52 100644 --- a/packages/core/src/modules/discover-features/DiscoverFeaturesApi.ts +++ b/packages/core/src/modules/discover-features/DiscoverFeaturesApi.ts @@ -121,7 +121,10 @@ export class DiscoverFeaturesApi< // Return disclosures map((e) => e.payload.disclosures), // If we don't have an answer in timeoutMs miliseconds (no response, not supported, etc...) error - timeout(options.awaitDisclosuresTimeoutMs ?? 7000), // TODO: Harmonize default timeouts across the framework + timeout({ + first: options.awaitDisclosuresTimeoutMs ?? 7000, + meta: 'DiscoverFeaturesApi.queryFeatures', + }), // TODO: Harmonize default timeouts across the framework // We want to return false if an error occurred catchError(() => of([])) ) diff --git a/packages/core/src/modules/oob/OutOfBandApi.ts b/packages/core/src/modules/oob/OutOfBandApi.ts index c4e65ccd57..1a0ae3cf4a 100644 --- a/packages/core/src/modules/oob/OutOfBandApi.ts +++ b/packages/core/src/modules/oob/OutOfBandApi.ts @@ -875,7 +875,10 @@ export class OutOfBandApi { ), // If the event is found, we return the value true map(() => true), - timeout(15000), + timeout({ + first: 15000, + meta: 'OutOfBandApi.handleHandshakeReuse', + }), // If timeout is reached, we return false catchError(() => of(false)) ) diff --git a/packages/core/src/modules/routing/MediationRecipientApi.ts b/packages/core/src/modules/routing/MediationRecipientApi.ts index 1b4cc75b69..f3a97681b9 100644 --- a/packages/core/src/modules/routing/MediationRecipientApi.ts +++ b/packages/core/src/modules/routing/MediationRecipientApi.ts @@ -428,7 +428,10 @@ export class MediationRecipientApi { // Only wait for first event that matches the criteria first(), // Do not wait for longer than specified timeout - timeout(timeoutMs) + timeout({ + first: timeoutMs, + meta: 'MediationRecipientApi.requestAndAwaitGrant', + }) ) .subscribe(subject) diff --git a/packages/core/src/modules/routing/services/MediationRecipientService.ts b/packages/core/src/modules/routing/services/MediationRecipientService.ts index c61e50bd54..dc464289b8 100644 --- a/packages/core/src/modules/routing/services/MediationRecipientService.ts +++ b/packages/core/src/modules/routing/services/MediationRecipientService.ts @@ -186,7 +186,10 @@ export class MediationRecipientService { // Only wait for first event that matches the criteria first(), // Do not wait for longer than specified timeout - timeout(timeoutMs) + timeout({ + first: timeoutMs, + meta: 'MediationRecipientService.keylistUpdateAndAwait', + }) ) .subscribe(subject)