Add account uid to system.notification.account #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffw8
suggested changes
Jun 14, 2018
rxx
force-pushed
the
bugfix/event_account_uid
branch
from
43ad8ef
to
4ea6440
Compare
|
@maksim-litvinov shouldn't we use uid instead of account_uid ? |
rxx
force-pushed
the
bugfix/event_account_uid
branch
from
4ea6440
to
a7bed6c
Compare
geoffw8
suggested changes
Jun 15, 2018
app/mailers/account_mailer.rb
Outdated
| @@ -8,12 +8,14 @@ def confirmation_instructions(record, token, opts = {}) | |||
| end | |||
|
|
|||
| def reset_password_instructions(record, token, opts = {}) | |||
| EventAPI.notify('system.notification.account', reset_password_token: token) | |||
| EventAPI.notify('system.notification.account', | |||
There was a problem hiding this comment.
I think the naming keys here are the wrong way round, it should actually be system.account.notification right?
Also - how comes this isn't actually system.account.forgotten_password?
rxx
force-pushed
the
bugfix/event_account_uid
branch
from
a7bed6c
to
445539d
Compare
mod
approved these changes
Jun 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.