Add filter by date in market/trades REST API call #2126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysv
reviewed
Mar 18, 2019
There was a problem hiding this comment.
You can try to use
coerce_with: ->(t) { Time.at(t.downcase) }as mentioned here https://github.com/ruby-grape/grape#custom-types-and-coercions
But if this requires many changes lets merge as it is
mod
requested changes
Mar 26, 2019
mnaichuk
force-pushed
the
api-improve-add-time-trades
branch
from
5eeaaa1
to
d3f8a73
Compare
ysv
approved these changes
Apr 3, 2019
mnaichuk
force-pushed
the
api-improve-add-time-trades
branch
from
d3f8a73
to
7a5ab75
Compare
mod
approved these changes
Apr 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.