Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add management API v1 #740

Merged
merged 57 commits into from Apr 4, 2018
Merged

Add management API v1 #740

merged 57 commits into from Apr 4, 2018

Conversation

yivo
Copy link

@yivo yivo commented Mar 24, 2018

No description provided.

@antonror
Copy link

antonror commented Mar 30, 2018

spec/models/withdraw_spec.rb:216
you have after_commit callback on cancel event in withdraw model, which reverts created withdraw to canceled and tries to unlock funds. created event locks no funds. a possible fix is to ensure aasm_state in callback method models/withdraw:152:

 def unlock_funds
    account.lock!
    account.unlock_funds sum, reason: Account::WITHDRAW_UNLOCK, ref: self unless aasm.from_state == :created
  end

@yivo
Copy link
Author

yivo commented Apr 3, 2018

image

@yivo yivo added PR: Approved and removed PR: QA labels Apr 3, 2018
check_query_parameters!
check_content_type!
payload = check_jwt!(jwt)
env['rack.input'] = StringIO.new(payload.fetch(:data, {}).to_json)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally payload is base 64 encoded, please double check the RFC

   payload
      The "payload" member MUST be present and contain the value
      BASE64URL(JWS Payload).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mod mod merged commit 859031d into openware:master Apr 4, 2018
yivo added a commit to yivo/peatio that referenced this pull request Apr 4, 2018
Introducing Management API Alpha version, provide the ability to manage deposits and withdrawal with third-party RSA signed payload, Now Barong and AppLogic application can participate in fiat transfer logic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants