Skip to content
This repository has been archived by the owner on Dec 20, 2023. It is now read-only.

WoBle fragment size getters drop the high byte from fragment sizes #633

Open
bzbarsky-apple opened this issue Dec 2, 2020 · 0 comments
Open

Comments

@bzbarsky-apple
Copy link

In src/ble/WoBle.h, we have:

    inline void SetTxFragmentSize(uint8_t size) { mTxFragmentSize = size; };
    inline void SetRxFragmentSize(uint8_t size) { mRxFragmentSize = size; };

    uint16_t GetRxFragmentSize(void) { return mRxFragmentSize; };
    uint16_t GetTxFragmentSize(void) { return mTxFragmentSize; };
....
    uint16_t mRxFragmentSize;
...
    uint16_t mTxFragmentSize;

and various code passes uint16_t values to the setters. This silently drops the high byte of those values, which doesn't seem desirable.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant