Update UA parser to handle WKWebView on iOS #1657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NiklasMerz
approved these changes
Jul 10, 2024
Elchi3
reviewed
Jul 11, 2024
Member
Elchi3
left a comment
Elchi3
left a comment
There was a problem hiding this comment.
Will this mean "webview_ios" as the BCD id?
In the BCD PR you've put "WKWebView on iOS" as the name. Should we be consistent?
I guess either we want:
id: "webview_ios", name: "WebView iOS"
or
id: "wkwebview_ios", name: "WKWebView on iOS"
Member
Author
|
To be consistent with WebView on Android, I updated the name in BCD to just "WebView on iOS"! |
Elchi3
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the user agent parser to remap "WebKit iOS" as "WebView iOS".