Skip to content

Replace usages of Object.keys()#2054

Merged
queengooborg merged 6 commits intoopenwebdocs:mainfrom
caugner:avoid-object-keys
Jan 30, 2025
Merged

Replace usages of Object.keys()#2054
queengooborg merged 6 commits intoopenwebdocs:mainfrom
caugner:avoid-object-keys

Conversation

@caugner
Copy link
Copy Markdown
Contributor

@caugner caugner commented Jan 2, 2025

Fixes #2053.

  1. Converts browser-extension.json to array of objects.
  2. Replaces a Object.keys() usage with a for..in loop.

Before

image

After

image

Avoids `Object.keys()`, not available in Firefox 3.6 and earlier.
Copy link
Copy Markdown
Member

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formal change request, see above.

Copy link
Copy Markdown
Member

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes have now been applied!

@queengooborg queengooborg merged commit 285aca2 into openwebdocs:main Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Results don't show in Firefox 3.6 and earlier

2 participants