Add custom tests for sibling-count() and sibling-index() - #2453
Merged
Conversation
Member
Author
|
These are shipping in Chrome 138. Tested with Chrome 137 stable and 138 beta to verify the tests works. |
caugner
approved these changes
Jun 10, 2025
caugner
added a commit
to mdn/browser-compat-data
that referenced
this pull request
Jun 11, 2025
* Add sibling-count() and sibling-index() The data was collected from Chrome 137 (stable) and 138 (beta) using new tests in the collector: openwebdocs/mdn-bcd-collector#2453 These will be a single feature in web-features, so the same tag is used. * Update sibling-count.json * Update sibling-index.json * Update sibling-count.json * Update sibling-index.json * Apply suggestions from code review Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com> --------- Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
Contributor
|
Hey @foolip! This looks good, but the repository requires that all commits are signed. Could you sign the commit and force push real quick? |
Member
Author
|
@queengooborg I've pushed 4014f85, but strangely don't see any change on this PR even though AFAICT it's the right branch... |
foolip
force-pushed
the
sibling-count
branch
2 times, most recently
from
June 17, 2025 19:54
b4723b5 to
4014f85
Compare
queengooborg
approved these changes
Jun 18, 2025
queengooborg
left a comment
queengooborg
left a comment
Contributor
There was a problem hiding this comment.
Looks like the most recent push was successful -- thanks! LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.