Skip to content

Only test new_required & empty ctor on relevant ctors #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
queengooborg merged 2 commits into from
Nov 23, 2023
Merged

Only test new_required & empty ctor on relevant ctors #850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca329b8
Only test new_required & empty ctor on relevant ctors
Elchi3 Nov 16, 2023
ed57c51
Update test
Elchi3 Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions test-builder/javascript.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,14 +132,6 @@ describe("build (JavaScript)", () => {
code: '(function () {\n if (!("Object" in self)) {\n return { result: false, message: "Object is not defined" };\n }\n return bcd.testConstructor("Object", false);\n})();\n',
exposure: ["Window"],
},
"javascript.builtins.Object.Object.new_required": {
code: '(function () {\n if (!("Object" in self)) {\n return { result: false, message: "Object is not defined" };\n }\n return bcd.testConstructorNewRequired("Object");\n})();\n',
exposure: ["Window"],
},
"javascript.builtins.Object.Object.constructor_without_parameters": {
code: '(function () {\n if (!("Object" in self)) {\n return { result: false, message: "Object is not defined" };\n }\n try {\n new Object();\n return true;\n } catch (e) {\n return { result: false, message: e.message };\n }\n})();\n',
exposure: ["Window"],
},
"javascript.builtins.Object.assign": {
code: '"Object" in self && "assign" in Object',
exposure: ["Window"],
Expand Down Expand Up @@ -174,10 +166,6 @@ describe("build (JavaScript)", () => {
`,
exposure: ["Window"],
},
"javascript.builtins.AggregateError.AggregateError.new_required": {
code: '(function () {\n if (!("AggregateError" in self)) {\n return { result: false, message: "AggregateError is not defined" };\n }\n return bcd.testConstructorNewRequired("AggregateError");\n})();\n',
exposure: ["Window"],
},
"javascript.builtins.Array": {
code: '"Array" in self',
exposure: ["Window"],
Expand All @@ -200,10 +188,6 @@ describe("build (JavaScript)", () => {
`,
exposure: ["Window"],
},
"javascript.builtins.Array.Array.new_required": {
code: '(function () {\n if (!("Array" in self)) {\n return { result: false, message: "Array is not defined" };\n }\n return bcd.testConstructorNewRequired("Array");\n})();\n',
exposure: ["Window"],
},
"javascript.builtins.Array.at": {
code: '"Array" in self && "at" in Array.prototype',
exposure: ["Window"],
Expand Down
75 changes: 54 additions & 21 deletions test-builder/javascript.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,35 +243,68 @@ const buildConstructorTests = async (tests, path: string, data: any = {}) => {
}

if (!data.no_new) {
tests[`${path}.new_required`] = compileTest({
raw: {
code: (
await compileCustomTest(
baseCode + `return bcd.testConstructorNewRequired("${iface}")`,
)
).code,
},
exposure: ["Window"],
});
const relevantCtors = [
"ArrayBuffer",
"DataView",
"Float32Array",
"Float64Array",
"Int16Array",
"Int32Array",
"Int8Array",
"Map",
"Set",
"TypedArray",
"Uint16Array",
"Uint32Array",
"Uint8Array",
"Uint8ClampedArray",
"WeakMap",
];
if (relevantCtors.includes(iface)) {
tests[`${path}.new_required`] = compileTest({
raw: {
code: (
await compileCustomTest(
baseCode + `return bcd.testConstructorNewRequired("${iface}")`,
)
).code,
},
exposure: ["Window"],
});
}
}

if (data.optional_args) {
tests[`${path}.constructor_without_parameters`] = compileTest({
raw: {
code: (
await compileCustomTest(
baseCode +
`try {
const relevantCtors = [
"Float32Array",
"Float64Array",
"Int16Array",
"Int32Array",
"Int8Array",
"TypedArray",
"Uint16Array",
"Uint32Array",
"Uint8Array",
"Uint8ClampedArray",
];
if (relevantCtors.includes(iface)) {
tests[`${path}.constructor_without_parameters`] = compileTest({
raw: {
code: (
await compileCustomTest(
baseCode +
`try {
new ${iface}();
return true;
} catch(e) {
return {result: false, message: e.message};
}`,
)
).code,
},
exposure: ["Window"],
});
)
).code,
},
exposure: ["Window"],
});
}
}

// Add the additional tests
Expand Down