-
-
Notifications
You must be signed in to change notification settings - Fork 26
Collect events #879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect events #879
Conversation
This change was discussed during the BCD call on November 30, 2022. The meeting notes state why they were disabled: That's why #133 was proposed instead. |
|
I know the Global/WindowEventHandlers need a mapping before we can enable these again. We definitely don't want the collector to add these entries all over the place and that's why I skipped them in this PR. I also added Serial events to be ignored but there are surely more events that bubble which we want to ignore. I think we should probably have better ignore code than what I did for Serial here. I'm thinking though that enabling this back on should allow us to test support for legit events again and discover new legit events? Seems like that is totally turned off now, right? |
|
Main: 4657/15217 (30.60%) entries missing from collector that are in bcd |
queengooborg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I see that this doesn't add any new features either (by running npm run find-missing-features bcd-from-collector), so let's merge this.
Unfortunately, I see no more context for 8f23515. There was no pull request...
I'm suggesting to add event collections back but ignore everything that has to do with GlobalEventHandlers and WindowEventHandlers for now.
(Also, I know Serial events can be ignored due to bubbling to SerialPort. Added that exception in as well.)