Skip to content

fix: code issues and nits #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
queengooborg merged 5 commits into from
Dec 15, 2023
Merged

fix: code issues and nits #977

queengooborg merged 5 commits into from
Dec 15, 2023

Conversation

@OnkarRuikar
Copy link
Contributor

@OnkarRuikar OnkarRuikar commented Dec 15, 2023 •
edited by queengooborg
Loading

The PR fixes

  • substr() is deprecated, use substring()
  • <a> tag is not closed in one HTML file
  • unused local variables
  • redundant ;

queengooborg
queengooborg requested changes Dec 15, 2023
View reviewed changes
queengooborg
queengooborg reviewed Dec 15, 2023
View reviewed changes
queengooborg
queengooborg reviewed Dec 15, 2023
View reviewed changes
@queengooborg queengooborg merged commit 20fdc18 into openwebdocs:main Dec 15, 2023
@OnkarRuikar OnkarRuikar deleted the code_issues branch December 15, 2023 16:39
@OnkarRuikar OnkarRuikar mentioned this pull request Dec 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@queengooborg queengooborg queengooborg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@OnkarRuikar @queengooborg