Permalink
Commits on Jan 24, 2014
  1. fix Coverity issues

    :Release Notes:
    Fix Coverity issues
    
    :Detailed Notes:
    Fix unchecked return values: 10895-10899, 44080
    Fix Unsigned compare against 0: 17729
    Fix Unintialized scalar field: 38173-38174
    
    :Testing Performed:
    Built image, tested that normal configurator functionality works
    
    :QA Notes:
    
    :Issues Addressed:
    [GF-53844] Fix coverity issues in configurator
    
    Open-webOS-DCO-1.0-Signed-off-by: Eric Blade <eric.blade@lge.com>
    
    Change-Id: Iba1838b0cd6778550a233293f91fdfde4496ebe4
    Reviewed-on: https://g2g.palm.com/4465
    Reviewed-by: DCO Verification
    Reviewed-by: Eric Blade <eric.blade@lge.com>
    Tested-by: Eric Blade <eric.blade@lge.com>
    Reviewed-by: Maksym Sditanov <maxim.sditanov@lge.com>
    Eric Blade committed with Maksym Sditanov Jan 23, 2014
Commits on Dec 11, 2013
  1. Fix obvious potential crash conditions

    :Release Notes:
    PMLOGKFV() should be used to format numbers.
    
    :Detailed Notes:
    
    :Testing Performed:
    Build succeeded
    Checked on qemux86
    
    :QA Notes:
    
    :Issues Addressed:
    [GF-54636] Excessive crashes in Configurator /lib/libc.so.6(strlen+0x4)
    
    Open-webOS-DCO-1.0-Signed-off-by: Anatolii Sakhnik <anatolii.sakhnik@lge.com>
    
    Change-Id: I01dd184646ef32848849e4c8df33f154cd3d4c04
    Reviewed-on: https://g2g.palm.com/4182
    Reviewed-by: DCO Verification
    Tested-by: Alekseyev Oleksandr <alekseyev.oleksandr@lge.com>
    Reviewed-by: Alexandr Smoktal <alexandr.smoktal@lge.com>
    Reviewed-by: Alekseyev Oleksandr <alekseyev.oleksandr@lge.com>
    sakhnik committed with jivchik Dec 10, 2013
Commits on Dec 2, 2013
  1. Switch to PmLogLib usage

    :Release Notes:
    Convert log messages to the new logging format
    
    :Detailed Notes:
    The exisiting logs have been categorized to the right level.
    They now log using the new msgid-key-value-format.
    
    :Testing Performed:
    tested on build
    
    :QA Notes:
    
    :Issues Addressed:
    [GF-52757] configurator: Use pmloglib for logging
    
    Open-webOS-DCO-1.0-Signed-off-by: Igor Kuksyuk <igor.kuksiuk@lge.com>
    
    Change-Id: Iaf716c7d5f41eb9efe91dc40be8eca847787f856
    Reviewed-on: https://g2g.palm.com/4067
    Reviewed-by: DCO Verification
    Reviewed-by: Igor Kuksyuk <igor.kuksiuk@lge.com>
    Tested-by: Igor Kuksyuk <igor.kuksiuk@lge.com>
    Reviewed-by: Maksym Sditanov <maxim.sditanov@lge.com>
    Tested-by: Maksym Sditanov <maxim.sditanov@lge.com>
    Igor committed with Maksym Sditanov Nov 27, 2013
Commits on Nov 19, 2013
  1. Validate input params

    :Release Notes:
    configurator validates input params like application or service id and return result of validating
    
    :Detailed Notes:
    If validation failed, return false with notification, that application
    or service doesn't exist
    
    :Testing Performed:
    Build locally, tested on TV
    
    :QA Notes:
    Wrong application:
    $ luna-send -n 1 palm://com.palm.configurator/scan '[{"id":"com.lge.app.chromium1","type":"app","location":"system"}]'
    {"errorCode":-1000,"errorText":"Aplication or service doesn't exist","returnValue":false}
    
    :Issues Address:
    [GF-11669]  configurator/scan - Returns true value for invalid argument
    
    Open-webOS-DCO-1.0-Signed-off-by: Yurii Makogon <yurii.makogon@lge.com>
    
    Change-Id: I7363f3e47345dd46b76cd1530bbc241e8d8018e6
    Reviewed-on: https://g2g.palm.com/3912
    Reviewed-by: DCO Verification
    Reviewed-by: Igor Kuksyuk <igor.kuksiuk@lge.com>
    Tested-by: Igor Kuksyuk <igor.kuksiuk@lge.com>
    Reviewed-by: Maksym Sditanov <maxim.sditanov@lge.com>
    Tested-by: Maksym Sditanov <maxim.sditanov@lge.com>
    Yurii Makogon committed with Maksym Sditanov Nov 18, 2013
  2. Array validating as input params

    :Realease Notes:
    Make configurator service workable
    
    :Detailed Notes:
    Add verification for input array params
    
    :Testing Performed:
    tested on build
    
    :QA Notes:
    $ luna-send -n 1 palm://com.palm.configurator/scan '[{"id":"com.lge.app.chromium","type":"app","location":"system"}]'
    {"configured":0,"returnValue":true}
    
    :Issues Address:
    [GF-11669] configurator/scan - Returns true value for invalid argument
    
    Open-webOS-DCO-1.0-Signed-off-by: Yurii Makogon <yurii.makogon@lge.com>
    Open-webOS-DCO-1.0-Signed-off-by: Igor Kuksyuk <igor.kuksiuk@lge.com>
    
    Change-Id: I492c0a475c9191ede5bfb970837774078f85ec9e
    Reviewed-on: https://g2g.palm.com/3890
    Reviewed-by: DCO Verification
    Reviewed-by: Igor Kuksyuk <igor.kuksiuk@lge.com>
    Tested-by: Igor Kuksyuk <igor.kuksiuk@lge.com>
    Reviewed-by: Maksym Sditanov <maxim.sditanov@lge.com>
    Tested-by: Maksym Sditanov <maxim.sditanov@lge.com>
    Yurii Makogon committed with Maksym Sditanov Nov 15, 2013
Commits on Nov 13, 2013
  1. Validate input params

    :Release Notes:
    configurator validates input params like application id and location
    and return correct result of validating
    
    :Detailed Notes:
    If validation failed, return false with notification, that application
    or location is wrong
    
    :Testing Performed:
    Build locally, tested on TV
    
    :QA Notes:
    Wrong id:
    $ luna-send -n 1 palm://com.palm.configurator/scan '{"id":"com.lge.app.chromium1","type":"web","location":"/usr/palm/applications"}'
    {"errorCode":-1000,"errorText":"Aplication doesn't exist","returnValue":false}
    
    Wrong location:
    $ luna-send -n 1 palm://com.palm.configurator/scan '{"id":"com.lge.app.chromium","type":"web","location":"/usr/palm/applications1"}'
    {"errorCode":-1000,"errorText":"Location doesn't exist","returnValue":false}
    
    :Issues Address:
    [GF-11669]  configurator/scan - Returns true value for invalid argument
    
    Open-webOS-DCO-1.0-Signed-off-by: Yurii Makogon <yurii.makogon@lge.com>
    
    Change-Id: I5374489a5cc753af4fe74c951387df62f70e2409
    Reviewed-on: https://g2g.palm.com/3819
    Reviewed-by: Build Verification
    Reviewed-by: Yurii Makogon <yurii.makogon@lge.com>
    Tested-by: Yurii Makogon <yurii.makogon@lge.com>
    Reviewed-by: Maksym Sditanov <maxim.sditanov@lge.com>
    Tested-by: Maksym Sditanov <maxim.sditanov@lge.com>
    Yurii Makogon committed with Maksym Sditanov Nov 8, 2013
Commits on Oct 28, 2013
  1. Move some info and notice logs to debug

    :Release Notes:
    Move some info and notice logs to debug, since info level
    is used only for logging metrics information
    
    :Detailed Notes:
    Info level is used for logging only metrics information.
    Non-metric logs are used for debugging purpose and is now
    moved to debug level.
    
    :Testing Performed:
    Compiled and verified logs on the device
    
    :QA Notes:
    
    :Issues Addressed:
    [GF-42671] Configurator is logging debug messages at info level
    
    Open-webOS-DCO-1.0-Signed-off-by: Gayathri Srinivasan <gayathri.srinivasan@lge.com>
    Change-Id: I349b723e41dfd1ecfa0d65b607b1817a71e1de86
    Reviewed-on: https://g2g.palm.com/3695
    Reviewed-by: Build Verification
    Reviewed-by: Gayathri Srinivasan <gayathri.srinivasan@lge.com>
    Tested-by: Gayathri Srinivasan <gayathri.srinivasan@lge.com>
    Reviewed-by: Keith Derrick <keith.derrick@lge.com>
    Gayathri Srinivasan committed with kdopen Oct 21, 2013
Commits on Sep 24, 2013
  1. Update configurator for com.webos.mediadb

    :Release Notes:
    Update configurator for com.webos.mediadb, supporting importing of Kinds
    and Permissions for this.
    Add additional logging.
    Raised version to #3 and set dependent on DB8 v3.
    
    :Detailed Notes:
    
    :Testing Performed:
    Boot and examine log files
    mini-BAT
    
    :QA Notes:
    
    :Issues Addressed:
    [GF-31429] mediadb: Extend mediadb support in DB8
    
    Open-webOS-DCO-1.0-Signed-off-by: Roger Stringer <roger.stringer@lge.com>
    
    Change-Id: I1c0c881e3687bab713c9f85d102313ff2f8ff88d
    Reviewed-on: https://g2g.palm.com/3446
    Reviewed-by: Build Verification
    Tested-by: Roger Stringer <roger.stringer@lge.com>
    Reviewed-by: Eric Blade <eric.blade@lge.com>
    Reviewed-by: Roger Stringer <roger.stringer@lge.com>
    RS102839 committed Sep 24, 2013
Commits on Sep 11, 2013
  1. CMakeLists: Enable USE_PMLOG flag

    :Release Notes:
    Turn on USE_PMLOG to enable logging using pmloglib's new functions
    via the MojLog class.
    Add PmLogLib detection to CMakeLists.txt
    
    :Detailed Notes:
    
    :Testing Performed:
     Tested on local environment
    
    :QA Notes:
    
    :Issues Addressed:
    [GF-30172] Configurator: Conform to new PmLogLib specifications
    
    Open-webOS-DCO-1.0-Signed-off-by: Shrinivas Kulkarni <shrinivas.kulkarni@lge.com>
    
    Change-Id: Id69565f9dbd4450a87fed6eb5ee90b2d415ecd79
    Reviewed-on: https://g2g.palm.com/3201
    Reviewed-by: Build Verification
    Reviewed-by: Roger Stringer <roger.stringer@lge.com>
    Tested-by: Roger Stringer <roger.stringer@lge.com>
    Shrinivas Kulkarni committed with RS102839 Aug 29, 2013
Commits on Jul 29, 2013
  1. Assign Copyright to LG Electronics, Inc.

    [GF-5644] Convert HP Copyright to LG
    
    Open-webOS-DCO-1.0-Signed-off-by: Maksym Shevchenko <myshevchenko@luxoft.com>
    
    Change-Id: I662bbce5aa373349adc52254e1a5507ed98766f3
    Reviewed-on: https://g2g.palm.com/2643
    Reviewed-by: Suresh Arumugam <suresh.arumugam@lge.com>
    Tested-by: Suresh Arumugam <suresh.arumugam@lge.com>
    maksym-shevchenko-owo committed with Suresh Arumugam Jun 13, 2013
  2. Modify Upstart 1.8 job files

    :Release Notes:
    This fix is modifying the Upstart 1.8 job files.
    
    :Detailed Notes:
    Configurator configures db, filecache and activity.
    There are two upstart scripts for the roles.
     1. configurator.conf : db, filecache
     2. configurator-async.conf : activity
    
    Therefore, right boot sequence is ...
    
     db8.conf & filecache.conf
     configurator.conf : configure db8, filecache
     datastore-initialized (upstart signal)
     activitymanager.conf
     activitymanager-ready (upstart signal)
     configurator-aync.conf : configure activity
    
    :Testing Performed:
    I tested this commit using upstart 1.8.
    
    :QA Notes:
    
    :Issues Addressed:
    [GF-5620] update coreOS upstart scripts for 1.8
    [GF-10057] MiniBAT failed: Launch Calendar app and confirm that it launches successfully.
    
    Open-webOS-DCO-1.0-Signed-off-by: Sangwoo Kang <sangwoo82.kang@lge.com>
    
    Change-Id: I40fa46312435864aca6d9e426130f75d10be52c4
    Reviewed-on: https://g2g.palm.com/2915
    Tested-by: Sangwoo Kang <sangwoo82.kang@lge.com>
    Reviewed-by: Ed Chejlava <ed.chejlava@lge.com>
    Reviewed-by: Build Verification
    Reviewed-by: Wonhong Kwon <wonhong.kwon@lge.com>
    Reviewed-by: Sangwoo Kang <sangwoo82.kang@lge.com>
    Reviewed-by: Suresh Arumugam <suresh.arumugam@lge.com>
    Tested-by: Suresh Arumugam <suresh.arumugam@lge.com>
    Sangwoo Kang committed with Suresh Arumugam Jul 24, 2013
Commits on Jul 10, 2013
  1. add Upstart 1.8 job files

    :Release Notes:
    This fix is simply moving the Upstart 1.8 job files for configurator
    from the starfish-initscripts package to their proper home.
    
    :Detailed Notes:
    As mentioned above, this fix is just moving the upstart script - in the
    initial implementation of Upstart 1.8, many 'component' upstart jobs
    were modified for 1.8 and packaged with starfish-initscripts to ease
    the transition from Upstart 0.3.11 to 1.8.  The plan was and is to
    move the 'imported' scripts back to their home package as soon as is
    reasonable.
    
    :Testing Performed:
    Since the file itself is functionally unchanged from that present in
    starfish-initscripts, the testing done running Upstart 1.8 + s-i over
    the last couple of months still applies.
    
    The testing done specifically for this fix is to locally build the
    component and inspect the output directory:
    starfish/BUILD-goldfinger/work/armv7a-vfp-neon-starfish-linux-gnueabi/ \
       /configurator/2.0.0-48-r2starfish1/image/etc/init and ..../etc/event.d
    to confirm that the properly configured upstart scripts end up in their
    respective locations.
    
    :QA Notes:
    
    :Issues Addressed:
    [GF-5620]  update coreOS upstart scripts for 1.8
    
    Open-webOS-DCO-1.0-Signed-off-by: Ed Chejlava <ed.chejlava@lge.com>
    
    Change-Id: I7907ef6d1258e387602334602a2755bde2742286
    Reviewed-on: https://g2g.palm.com/2711
    Reviewed-by: Build Verification
    Reviewed-by: Ed Chejlava <ed.chejlava@lge.com>
    Tested-by: Ed Chejlava <ed.chejlava@lge.com>
    Reviewed-by: Suresh Arumugam <suresh.arumugam@lge.com>
    Tested-by: Suresh Arumugam <suresh.arumugam@lge.com>
    Ed Chejlava committed with Suresh Arumugam Jun 22, 2013
Commits on Jul 3, 2013
  1. Fix API documentation comments

    Removed blank lines between Parameters/Returns heading and their tables
    Changed API documentation header and footer
    Added None below Parameters & Returns where applicable
    Open-webOS-DCO-1.0-Signed-off-by: Kalindi Pathare <kalindi.pathare@lge.com>
    
    Change-Id: Id1912ae234420eb9986484a4d1272ce8607f059b
    Reviewed-on: https://g2g.palm.com/2732
    Reviewed-by: Build Verification
    Reviewed-by: Suresh Arumugam <suresh.arumugam@lge.com>
    Tested-by: Suresh Arumugam <suresh.arumugam@lge.com>
    kalindipatharelg committed with Suresh Arumugam Jun 24, 2013
Commits on Jun 16, 2013
  1. Add documentation to all service methods

    Open-webOS-DCO-1.0-Signed-off-by: Suresh Arumugam <suresh.arumugam@lge.com>
    
    Change-Id: I753de32a6024528708693df3a99e7144e79f8dae
    Suresh Arumugam committed Jun 16, 2013
Commits on Nov 29, 2012
  1. Explicitely link pthread

    Gold linker requires explicit linking of pthread.
    
    Open-webOS-DCO-1.0-Signed-off-by: Jose Dapena Paz <jose.dapena@palm.com>
    
    Change-Id: I4fdd9871ac02077a8772ded242dd6be1613475db
    jdapena committed Nov 27, 2012
Commits on Oct 31, 2012
  1. Use pkg-config to locate db8

    Open-webOS-DCO-1.0-Signed-off-by: Eric Blade <eric.blade@palm.com>
    
    Change-Id: If1ee5ca70ed0792cac594c35bc3e82442f507398
    ericblade-owo committed Oct 31, 2012
Commits on Sep 26, 2012
  1. Remove MOJ_X86 compiler flag

    Open-webOS-DCO-1.0-Signed-off-by: Suresh Arumugam <suresh.arumugam@palm.com>
    
    Change-Id: Iee498ab9d3825ea55e8ee3b61bd5fd6a9d8180b5
    sarumugam committed Sep 26, 2012
  2. Use stat to get the file information instead of dirent d_type

    Open-webOS-DCO-1.0-Signed-off-by: Suresh Arumugam <suresh.arumugam@palm.com>
    
    Change-Id: I11562200d4146c1d9ab3bd14a4deabf2b536f52e
    sarumugam committed Sep 26, 2012
Commits on Sep 19, 2012
  1. Update the CMake file to copy the upstart files.

    Open-webOS-DCO-1.0-Signed-off-by: Suresh Arumugam <suresh.arumugam@palm.com>
    
    Change-Id: Ic0c0407d76635ffa703fa59d0ccb90c3035fe58b
    sarumugam committed Sep 19, 2012
Commits on Sep 11, 2012
  1. Disable the FirstUse run check.

    Change-Id: I2c9ea915cadf9409f030bb9792685a96e8d4eea8
    sarumugam committed Sep 11, 2012
Commits on Sep 7, 2012
  1. Modified to use WEBOS_INSTALL_STATEDIR to save its stamp files

    Change-Id: Ifb72345b3621434212058bf183df862cffe0fa29
    sarumugam committed Sep 7, 2012
Commits on Aug 29, 2012
  1. CMake Changes

    Change-Id: I94677cb326c1fa8bac271e5ae275e3756bb6b07c
    sarumugam committed Aug 29, 2012
  2. Support Desktop build

    Change-Id: I3fbfc9f9516de4447d1f0edb72644861734379c6
    RS102839 committed Aug 29, 2012
  3. Remove build artefacts

    Change-Id: Icd037c10e5e994a82c51825199161f5e993e549a
    RS102839 committed Aug 29, 2012
Commits on Aug 27, 2012
  1. Modified CMake file. Added launch and sysbus files.

    Change-Id: If4c78f1cdb3e0319a1508b33b57af10a447c39f0
    sarumugam committed Aug 27, 2012
Commits on Aug 20, 2012
  1. Added CMake file

    Suresh Arumugam committed Aug 20, 2012
Commits on Jul 12, 2012
  1. cleanup configurator

    sarumugam committed Jul 12, 2012
  2. Added Configurator

    sarumugam committed Jul 12, 2012
  3. Removed Configurator

    sarumugam committed Jul 12, 2012
  4. Adding Configurator

    sarumugam committed Jul 12, 2012
  5. deleted configurator

    sarumugam committed Jul 12, 2012
  6. deleted configurator

    sarumugam committed Jul 12, 2012
  7. Adding Configurator

    sarumugam committed Jul 12, 2012