Fix up warnings reported by jshint.

Remove jslint global declarations. Open-webOS-DCO-1.0-Signed-off-by: Jason Lai <jason.lai@palm.com> Change-Id: I84c1338761e4581ad03deb61c7af15dd916bebd9
openwebos · Sep 25, 2012 · 2e37683 · 2e37683
1 parent 80da791
commit 2e37683
Show file tree

Hide file tree

Showing 35 changed files with 199 additions and 215 deletions.
diff --git a/com.palm.app.email/.jshintignore b/com.palm.app.email/.jshintignore
@@ -0,0 +1,2 @@
+util/lib/
+util/urlparser.js
diff --git a/com.palm.app.email/accounts/source/AccountWizard.js b/com.palm.app.email/accounts/source/AccountWizard.js
@@ -740,8 +740,7 @@ AccountWizard.prototype.makeEasUsernameFromEmail = function (email) {
         username = email.replace("@" + domain, ""); // get left side of email address
     }
     return username;
-}
-
+};
 
 /**
  * Special fn for creating palm and related account accounts

diff --git a/com.palm.app.email/accounts/source/CRUDAccounts.js b/com.palm.app.email/accounts/source/CRUDAccounts.js
@@ -418,11 +418,11 @@ enyo.kind({
                 useSmtpAuth: true,
                 encryption: "",
                 port: "",
-                server: "",
+                server: ""
             },
             type: (this.wizardTemplate.templateId === "com.palm.eas" ? AccountWizard.EAS : ""),
             templateId: this.wizardTemplate.templateId
-        }
+        };
     },
 
     /**

diff --git a/com.palm.app.email/accounts/source/ManualConfig.js b/com.palm.app.email/accounts/source/ManualConfig.js
@@ -55,8 +55,8 @@ enyo.kind({
                         onChange: "accountTypeChanged",
                         items: [
                             {caption: $L("IMAP"), value: AccountWizard.IMAP},
-                            {caption: $L("POP"), value: AccountWizard.POP}
-                           /* {caption: $L("EAS"), value: AccountWizard.EAS} /* , showing: false */
+                            {caption: $L("POP"), value: AccountWizard.POP},
+                            {caption: $L("EAS"), value: AccountWizard.EAS, showing: false}
                         ]
                     }
                 ]},
@@ -66,7 +66,7 @@ enyo.kind({
                     className: "accounts-group",
                     caption: $L("EMAIL ADDRESS"),
                     components: [
-                        {name: "email", kind: "Input", inputType: "email", value: "", onkeypress: "isFormComplete", onkeydown: "checkEnter", onkeydown: "checkEnter", spellcheck: false, autocorrect: false, className: "babelfish", onblur: "isFormComplete", autoCapitalize: "lowercase"}
+                        {name: "email", kind: "Input", inputType: "email", value: "", onkeypress: "isFormComplete", onkeydown: "checkEnter", spellcheck: false, autocorrect: false, className: "babelfish", onblur: "isFormComplete", autoCapitalize: "lowercase"}
                     ]
                 },
                 {
@@ -75,27 +75,27 @@ enyo.kind({
                     caption: $L("INCOMING MAIL SERVER"),
                     components: [
                         {kind: "InputBox", components: [
-                            {name: "inHost", kind: "Input", className: "enyo-first", flex: 1, value: "", hint: $L("Server"), spellcheck: false, autocorrect: false, className: "babelfish", autoCapitalize: "lowercase", onkeypress: "isFormComplete", onkeydown: "checkEnter", onblur: "isFormComplete", components: [
+                            {name: "inHost", kind: "Input", className: "enyo-first babelfish", flex: 1, value: "", hint: $L("Server"), spellcheck: false, autocorrect: false, autoCapitalize: "lowercase", onkeypress: "isFormComplete", onkeydown: "checkEnter", onblur: "isFormComplete", components: [
                                 {content: $L("Server")}
-                            ]},
+                            ]}
                         ]},
 
                         {name: "inEas", components: [
                             {kind: "InputBox", components: [
-                                {name: "domain", kind: "Input", className: "enyo-middle", flex: 1, value: "", hint: $L("Domain"), spellcheck: false, autocorrect: false, className: "babelfish", autoCapitalize: "lowercase", onkeypress: "isFormComplete", onkeydown: "checkEnter", onblur: "isFormComplete", components: [
+                                {name: "domain", kind: "Input", className: "enyo-middle babelfish", flex: 1, value: "", hint: $L("Domain"), spellcheck: false, autocorrect: false, autoCapitalize: "lowercase", onkeypress: "isFormComplete", onkeydown: "checkEnter", onblur: "isFormComplete", components: [
                                     {content: $L("Domain")}
-                                ]},
+                                ]}
                             ]}
                         ]},
                         {kind: "InputBox", components: [
-                            {name: "inUser", kind: "Input", className: "enyo-middle", flex: 1, value: "", hint: $L("Username"), spellcheck: false, autocorrect: false, className: "babelfish", autoCapitalize: "lowercase", onblur: "copyUserToOut", onkeypress: "isFormComplete", onkeydown: "checkEnter", components: [
+                            {name: "inUser", kind: "Input", className: "enyo-middle babelfish", flex: 1, value: "", hint: $L("Username"), spellcheck: false, autocorrect: false, autoCapitalize: "lowercase", onblur: "copyUserToOut", onkeypress: "isFormComplete", onkeydown: "checkEnter", components: [
                                 {content: $L("Username")}
-                            ]},
+                            ]}
                         ]},
                         {kind: "InputBox", components: [
-                            {name: "inPassword", kind: "Input", className: "enyo-middle", flex: 1, inputType: "password", value: "", hint: $L("Password"), spellcheck: false, autocorrect: false, className: "babelfish", autoCapitalize: "lowercase", onblur: "copyPassToOut", onkeypress: "isFormComplete", onkeydown: "checkEnter", onfocus: "checkInPass", components: [
+                            {name: "inPassword", kind: "Input", className: "enyo-middle babelfish", flex: 1, inputType: "password", value: "", hint: $L("Password"), spellcheck: false, autocorrect: false, autoCapitalize: "lowercase", onblur: "copyPassToOut", onkeypress: "isFormComplete", onkeydown: "checkEnter", onfocus: "checkInPass", components: [
                                 {content: $L("Password")}
-                            ]},
+                            ]}
                         ]},
                         {name: "popImapIncoming", components: [
                             {
@@ -113,9 +113,9 @@ enyo.kind({
 
                         ]},
                         {kind: "InputBox", name: "inPortWrapper", components: [
-                            {name: "inPort", kind: "Input", className: "enyo-last", inputType: "number", value: "", hint: $L("Port"), spellcheck: false, autocorrect: false, className: "babelfish", flex: 1, autoCapitalize: "lowercase", onkeypress: "isFormComplete", onkeydown: "checkEnter", onblur: "isFormComplete", components: [
+                            {name: "inPort", kind: "Input", className: "enyo-last babelfish", inputType: "number", value: "", hint: $L("Port"), spellcheck: false, autocorrect: false, flex: 1, autoCapitalize: "lowercase", onkeypress: "isFormComplete", onkeydown: "checkEnter", onblur: "isFormComplete", components: [
                                 {content: $L("Port")}
-                            ]},
+                            ]}
                         ]}
 
                     ]
@@ -127,9 +127,9 @@ enyo.kind({
                     caption: $L("OUTGOING MAIL SERVER"),
                     components: [
                         {kind: "InputBox", components: [
-                            {name: "outHost", kind: "Input", className: "enyo-first", flex: 1, value: "", hint: $L("Server"), spellcheck: false, autocorrect: false, className: "babelfish", autoCapitalize: "lowercase", onkeypress: "isFormComplete", onkeydown: "checkEnter", onblur: "isFormComplete", components: [
+                            {name: "outHost", kind: "Input", className: "enyo-first babelfish", flex: 1, value: "", hint: $L("Server"), spellcheck: false, autocorrect: false, autoCapitalize: "lowercase", onkeypress: "isFormComplete", onkeydown: "checkEnter", onblur: "isFormComplete", components: [
                                 {content: $L("Server")}
-                            ]},
+                            ]}
                         ]},
                         {kind: "HFlexBox", align: "center", components: [
                             {flex: 1, content: $L("Use Authentication")},
@@ -138,17 +138,17 @@ enyo.kind({
                         {name: "outAuthBlock", kind: "Drawer", style: "margin:-10px;", open: false, components: [
                             {kind: "enyo.RowItem", components: [
                                 {kind: "InputBox", components: [
-                                    {name: "outUser", kind: "Input", className: "enyo-middle", flex: 1, value: "", className: "babelfish", hint: $L("Username"), spellcheck: false, autocorrect: false, autoCapitalize: "lowercase", onkeypress: "isFormComplete", onkeydown: "checkEnter", onblur: "isFormComplete", components: [
+                                    {name: "outUser", kind: "Input", className: "enyo-middle babelfish", flex: 1, value: "", hint: $L("Username"), spellcheck: false, autocorrect: false, autoCapitalize: "lowercase", onkeypress: "isFormComplete", onkeydown: "checkEnter", onblur: "isFormComplete", components: [
                                         {content: $L("Username")}
-                                    ]},
-                                ]},
+                                    ]}
+                                ]}
                             ]},
                             {kind: "enyo.RowItem", components: [
                                 {kind: "InputBox", components: [
-                                    {name: "outPassword", kind: "Input", className: "enyo-middle", flex: 1, inputType: "password", value: "", className: "babelfish", hint: $L("Password"), spellcheck: false, autocorrect: false, autoCapitalize: "lowercase", onkeypress: "isFormComplete", onkeydown: "checkEnter", onblur: "isFormComplete", onfocus: "checkOutPass", components: [
+                                    {name: "outPassword", kind: "Input", className: "enyo-middle babelfish", flex: 1, inputType: "password", value: "", hint: $L("Password"), spellcheck: false, autocorrect: false, autoCapitalize: "lowercase", onkeypress: "isFormComplete", onkeydown: "checkEnter", onblur: "isFormComplete", onfocus: "checkOutPass", components: [
                                         {content: $L("Password")}
-                                    ]},
-                                ]},
+                                    ]}
+                                ]}
                             ]},
                             {kind: "enyo.RowItem", components: [
                                 {
@@ -162,15 +162,15 @@ enyo.kind({
                                         {caption: $L("SSL"), value: ProtocolSettings.SSL},
                                         {caption: $L("TLS"), value: ProtocolSettings.TLS}
                                     ]
-                                },
+                                }
                             ]},
                             {kind: "enyo.RowItem", className: "enyo-last", components: [
                                 {kind: "InputBox", components: [
-                                    {name: "outPort", kind: "Input", className: "enyo-last", inputType: "number", value: "", hint: $L("Port"), spellcheck: false, autocorrect: false, flex: 1, autoCapitalize: "lowercase", onkeypress: "isFormComplete", onkeydown: "checkEnter", className: "babelfish", onblur: "isFormComplete", components: [
+                                    {name: "outPort", kind: "Input", className: "enyo-last babelfish", inputType: "number", value: "", hint: $L("Port"), spellcheck: false, autocorrect: false, flex: 1, autoCapitalize: "lowercase", onkeypress: "isFormComplete", onkeydown: "checkEnter", onblur: "isFormComplete", components: [
                                         {content: $L("Port")}
-                                    ]},
+                                    ]}
                                 ]}
-                            ]},
+                            ]}
                         ]}
 
                     ]
@@ -281,7 +281,7 @@ enyo.kind({
             }
 
             if (acctType === AccountWizard.POP) {
-                this.$.inPort.setValue((inEncryption === ProtocolSettings.SSL) ? 995 : 110)
+                this.$.inPort.setValue((inEncryption === ProtocolSettings.SSL) ? 995 : 110);
                 return;
             }
         }
@@ -376,7 +376,7 @@ enyo.kind({
             return false;
         }
 
-        var outPort = this.$.outPort.getValue()
+        var outPort = this.$.outPort.getValue();
         if (outPort < 1 || outPort > 65535) {
             //		console.log("### invalid out ports");
             return false;
@@ -441,7 +441,7 @@ enyo.kind({
         }
         this.$.createButton.setActive(true);
         var toUse = this.makeAccountJson();
-        toUse.dontValidate = dontValidate // used for forcing account creation
+        toUse.dontValidate = dontValidate; // used for forcing account creation
         var successCall = !!this.isEditMode ? this.handleSaveAccount : this.createSuccess;
         var failCall = this.createError;
         this.wizard.accountValidateManual(toUse, successCall, failCall);
@@ -470,10 +470,10 @@ enyo.kind({
                     port: this.$.outPort.getValue(),
                     server: this.$.outHost.getValue(),
                     password: this.$.outPassword.getValue(),
-                    username: this.$.outUser.getValue(),
+                    username: this.$.outUser.getValue()
                 }
             }
-        }
+        };
 
         // Add protocol-specific stuff
         if (this.account.getType() === AccountWizard.IMAP && this.isEditMode) {

diff --git a/com.palm.app.email/accounts/source/ProtocolSettings.js b/com.palm.app.email/accounts/source/ProtocolSettings.js
@@ -16,12 +16,6 @@
 //
 // LICENSE@@@
 
-/*global Mojo, $L, Class, window, document, PalmSystem, AppAssistant, palmGetResource, Foundations, _,
- App, console, Throttler, $H, $A, Event, $break, Element,
- Poly9, MailtoURIParser,
- EmailFlags, EmailRecipient, EmailAppDepot, AccountpreferencesAssistant, Email, EmailAccount, EmailDecorator,
- AccountWizard, EmailAccountValidation */
-
 /**ProtocolSettings: {
 
  name : accountName

diff --git a/com.palm.app.email/accounts/source/SimpleConfig.js b/com.palm.app.email/accounts/source/SimpleConfig.js
@@ -74,7 +74,7 @@ enyo.kind({
                 { name: "createButton", kind: "ActivityButton", caption: $L("Sign In"), onclick: "validateAccount", className: "enyo-button-dark"},
                 { name: "manualButton", showing: false, kind: "Button", caption: $L("Manual Setup"), onclick: "manualSetup"},
                 { name: "removeButton", showing: false, kind: "Accounts.RemoveAccount", onAccountsRemove_Done: "doRemovalDone"}
-            ]},
+            ]}
         ]},
         {className: "accounts-footer-shadow"},
         {kind: "Toolbar", className: "enyo-toolbar-light", components: [
@@ -208,7 +208,7 @@ enyo.kind({
                 emailAddress: this.$.email.getValue(),
                 password: this.$.password.getValue(),
                 easUser: ((this.account.getType() === AccountWizard.EAS) ? this.$.username.getValue() : undefined)
-            }
+            };
 
             this.wizard.determineAccountSettings(wizardPkg, this.createSuccess.bind(this), this.createError.bind(this));
             /*

diff --git a/com.palm.app.email/app/compose/ComposeWindow.js b/com.palm.app.email/app/compose/ComposeWindow.js
@@ -16,9 +16,6 @@
 //
 // LICENSE@@@
 
-/*global enyo, window, console, mail, EmailApp, Email, EmailRecipient, setTimeout, $L
- */
-
 // FIXME ComposeWindow needs to be refactored to make logic more transparent/maintainable
 
 enyo.string.isBlankRegExp = /^\s*$/;
@@ -82,7 +79,7 @@ enyo.kind({
     kind: "VFlexBox",
     className: "basic-back",
     statics: {
-        kForwardDraftDelimiter: "<span id='FORWARD_DRAFT_TEXT' class='display:none'></span>",
+        kForwardDraftDelimiter: "<span id='FORWARD_DRAFT_TEXT' class='display:none'></span>"
     },
     published: {
         draftIsDirty: false,
@@ -100,7 +97,7 @@ enyo.kind({
                             {name: "otherMenu", kind: "Menu", lazy: false, components: [
                                 {name: "priorityMenuItem", caption: $L("Mark as High Priority"), onclick: "priorityMenuItemClicked"},
                                 {name: "saveAsDraftMenuItem", caption: $L("Save As Draft"), onclick: "saveDraftClicked"},
-                                {name: "discardMessageMenuItem", caption: $L("Discard Message"), onclick: "discardMessage"},
+                                {name: "discardMessageMenuItem", caption: $L("Discard Message"), onclick: "discardMessage"}
                             ]}
                         ]},
                         {name: "attachButton", className: "attachment-button", kind: "CustomButton", onclick: "attachClick", style: "", components: []},
@@ -117,7 +114,7 @@ enyo.kind({
                 {name: "composeScroller", className: "compose-scroller", style: "background-color: white;", kind: "Scroller", accelerated: false, height: "100%", flex: "1", onscroll: "scrollerScroll", components: [
                     {kind: "VFlexBox", components: [
                         {kind: "VFlexBox", className: "compose-header", style: "background-color: #f1f1f1;", components: [
-                            {className: "enyo-row", className: "dotted-bottom", components: [
+                            {className: "enyo-row dotted-bottom", components: [
                                 {kind: "HFlexBox", height: "54px", style: "padding: 0 14px;", components: [
                                     {name: "fromLabel", className: "compose-to-text", style: "line-height:54px;margin-right:4px;", content: $L("from:")},
                                     {name: "from", kind: "ListSelector", style: "font-size:16px;", onChange: "senderAccountChanged", flex: 1, value: 0, items: []}
@@ -138,15 +135,15 @@ enyo.kind({
                                     {name: "subjectInput", style: "font-size:16px;", kind: "Input", className: "enyo-middle", flex: 1, onkeydown: "subjectKeydown", tabIndex: 40, oninput: "changeHandler"},
                                     {name: "priorityFlag", kind: "Image", src: "../images/compose-priority-flag.png", className: "compose-red-flag"}
                                 ]}
-                            ]},
+                            ]}
                         ]},
                         {name: "attachments", kind: "AttachmentsDrawer", className: "compose-attachments-drawer", composeMode: true, collapsible: true, onAttachmentsRemoved: "handleAttachmentsRemoved"},
                         {name: "bodyContainer", style: " background-color: white; ", components: [
                             {name: "bodyInput", kind: "RichText", hint: "", placeholderClassName: "", flex: 1, styled: false, tabIndex: 50, style: "padding:14px 14px 0px 14px; min-height: 75px; background-color: white;font-size:16px;", oninput: "changeHandler"},
-                            {name: "originalMessageBody", kind: "RichText", hint: "", placeholderClassName: "", styled: false, showing: false, flex: 1, style: "padding:0px 14px 14px 14px; background-color: white;", oninput: "changeHandler"},
+                            {name: "originalMessageBody", kind: "RichText", hint: "", placeholderClassName: "", styled: false, showing: false, flex: 1, style: "padding:0px 14px 14px 14px; background-color: white;", oninput: "changeHandler"}
                         ]}
                     ]}
-                ]},
+                ]}
             ]},
             {kind: "FilePicker", allowMultiSelect: true, onPickFile: "attachFiles"}
         ]},
@@ -195,11 +192,13 @@ enyo.kind({
         // Uncomment the ApplicationEvents component when removing this workaround.
         var that = this,
             $$ = this.$;
+
         var unloadFunc = function (e) {
             console.info("WINLOG: Compose window UNLOAD: " + window.name);
             that.unloadHandler(e);
             window.removeEventListener('unload', unloadFunc);
-        }
+        };
+
         window.addEventListener('unload', unloadFunc);
 
         this.populateMessage(enyo.windowParams);

diff --git a/com.palm.app.email/app/compose/Composition.js b/com.palm.app.email/app/compose/Composition.js
@@ -16,9 +16,6 @@
 //
 // LICENSE@@@
 
-/*global enyo, console, mail, EmailApp, EmailRecipient, $L
- */
-
 EmailApp = EmailApp || {};
 
 /*
@@ -849,7 +846,7 @@ EmailApp.Composition.prototype = {
         // NOTE: must not contain any "undefined" fields
         var newPart = {
             type: part.type || "attachment",
-            name: part.name || "",
+            name: part.name || ""
         };
 
         // Copy _id