Permalink
Browse files

Remove unused boundary enums

The symbols for the first and last values in the NYX_DEVICE_*,
NYX_DEVICE_INFO_* and NYX_OS_INFO_* enumerations were meant to
enable clients to iterate over the range of legal values. Instead
they simply caused an ABI break everytime a new value was added,
and were never used.

Therefore, they have been removed.

[GF-2451] Remove all iterator boundary values from ENUM's in API

Open-webOS-DCO-1.0-Signed-off-by: Keith Derrick <keith.derrick@lge.com>

Change-Id: I69d3cfc4fcf4a30d24e1f5c6a8093bb1f35f3f66
  • Loading branch information...
1 parent 677f32a commit 989fc4a02871e8b1ff1d2a7b88469ccd3d29edc2 @kdopen kdopen committed Mar 15, 2013
View
5 include/public/nyx/common/nyx_device.h
@@ -52,8 +52,7 @@ extern "C" {
*/
typedef enum {
NYX_DEVICE_ILLEGAL_DEVICE = 0,
- NYX_DEVICE_FIRST_VALID,
- NYX_DEVICE_BATTERY = NYX_DEVICE_FIRST_VALID,
+ NYX_DEVICE_BATTERY,
NYX_DEVICE_BLUETOOTH_INPUT_DETECT,
NYX_DEVICE_CHARGER,
NYX_DEVICE_DEVICE_INFO,
@@ -84,8 +83,6 @@ typedef enum {
NYX_DEVICE_MASS_STORAGE_MODE,
NYX_DEVICE_OS_INFO,
NYX_DEVICE_SECURITY,
- NYX_DEVICE_TYPE_COUNT, /* should always be the last, used primarly in testing
- for iterating over all known devices */
} nyx_device_type_t;
/**
View
3 include/public/nyx/common/nyx_device_info_common.h
@@ -37,7 +37,6 @@ extern "C" {
*/
typedef enum {
- NYX_DEVICE_INFO_START = 0,
NYX_DEVICE_INFO_BATT_CH,
NYX_DEVICE_INFO_BATT_RSP,
NYX_DEVICE_INFO_BOARD_TYPE,
@@ -63,8 +62,6 @@ typedef enum {
NYX_DEVICE_INFO_STORAGE_SIZE,
NYX_DEVICE_INFO_WIFI_ADDR,
NYX_DEVICE_INFO_HARDWARE_ID,
-
- NYX_DEVICE_INFO_END
} nyx_device_info_type_t;
/** @} */
View
4 include/public/nyx/common/nyx_os_info_common.h
@@ -37,8 +37,6 @@ extern "C" {
*/
typedef enum {
- NYX_OS_INFO_START = 0,
-
NYX_OS_INFO_CORE_OS_NAME,
NYX_OS_INFO_CORE_OS_RELEASE,
NYX_OS_INFO_CORE_OS_RELEASE_CODENAME,
@@ -53,8 +51,6 @@ typedef enum {
NYX_OS_INFO_WEBOS_IMAGENAME,
NYX_OS_INFO_WEBOS_API_VERSION,
NYX_OS_INFO_WEBOS_PRERELEASE,
-
- NYX_OS_INFO_END
} nyx_os_info_query_t;
/** @} */

0 comments on commit 989fc4a

Please sign in to comment.