Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Jun 5, 2014
  1. @kdopen

    Merge branch 'develop'

    kdopen authored
  2. @kdopen

    Add enumerant NYX_OS_INFO_ENCRYPTION_KEY_TYPE to nyx_os_info_query_t

    Sapna Todwal authored kdopen committed
    :Release Notes:
    Add a Nyx OS Info query NYX_OS_INFO_ENCRYPTION_KEY_TYPE that returns the
    type of encryption key used for signing.
    
    :Detailed Notes:
    - This change introduces the enumerant
      NYX_OS_INFO_WEBOS_MANUFACTURING_VERSION as an alias for the now
      deprecated NYX_OS_INFO_MANUFACTURING_VERSION.
    - Set version to v6.1.0 .
    
    :Testing Performed:
    Verified that with this change, nyx-modules is able to implement this
    new query.
    
    :Issues Addressed:
    [ANG-9167] Add Nyx OS Info query for type of key used for signing
    
    Open-webOS-DCO-1.0-Signed-off-by: Sapna Todwal <sapna.todwal@lge.com>
    
    Change-Id: I8c6e47b2f0c84a60eed534d01c0f6371a50a520e
    Reviewed-on: https://g2g.palm.com/5891
    Reviewed-by: DCO Verification
    Reviewed-by: Herb Kuta <herb.kuta@lge.com>
    Tested-by: Sapna Todwal <sapna.todwal@lge.com>
    Reviewed-by: Keith Derrick <keith.derrick@lge.com>
Commits on Oct 3, 2013
  1. @kdopen

    Remove parameter from nyx_system_erase_partition()

    kdopen authored
    :Release Notes:
    The nyx_system_erase_partition method API has changed to avoid buffer
    overflow errors.
    
    This API change takes nyx-lib (and it's modules) to v6.0.0
    
    :Detailed Notes:
    The nyx_system_erase_partition method had an "error message" parameter
    of type `char *`. The original intent was to return an error message
    through the pointer. However, without a buffer length parameter, there
    is simply no safe way to implement that.
    
    Alternatives were to either change it a 'char **' and return a
    dynamically allocated buffer (which raises the possibility of memory
    leaks), add a buffer length parameter (which seems a bit unnecessary
    overhead for an unlikley error condition), or simply delete the
    parameter from the API.
    
    As the method already has an error code return value, the third option
    was taken.
    
    Additionally, a new erase type (NYX_SYSTEM_ERASE_DEVELOPER) was added.
    
    :Testing Performed:
    Currently, nothing is using this method, so the only testing required
    is clean compilation.
    
    :QA Notes:
    
    :Issues Addressed:
    [GF-37730] Provide implementation of Nyx System module to support
               factory reset
    
    Open-webOS-DCO-1.0-Signed-off-by: Keith Derrick <keith.derrick@lge.com>
    Change-Id: I34bd7107b9945a18f1511c2cabe07da1f25be377
    Reviewed-on: https://g2g.palm.com/3561
    Reviewed-by: Build Verification
    Reviewed-by: Keith Derrick <keith.derrick@lge.com>
    Tested-by: Keith Derrick <keith.derrick@lge.com>
Commits on Sep 19, 2013
  1. @kdopen

    Cosmetic change to apply code formatting

    kdopen authored
    :Release Notes:
    All source code is now formatted in a consistent manner, including
    applying the tabs to indent, spaces to align convention.
    
    :Detailed Notes:
    The code formatting program 'Artistic Style' was used to clean up
    any inconsistent formatting prior to making subsequent changes in
    the code.
    
    The applied options are available in the new file 'astyle_options'.
    
    :Testing Performed:
    - Checked output of git diff -w -b --ignore-blank-lines
    - Check component still compiles
    - With 'ignore whitespace=all' set, scrubbed gerrit code review
    
    :QA Notes:
    
    :Issues Addressed:
    [GF-36641] Apply Artistic Style with standard options to nyx-lib
    
    Open-webOS-DCO-1.0-Signed-off-by: Keith Derrick <keith.derrick@lge.com>
    
    Change-Id: I680df4ea9e1e4eb564cc9d38630e8adae3a9af6d
    Reviewed-on: https://g2g.palm.com/3397
    Reviewed-by: Build Verification
    Reviewed-by: Keith Derrick <keith.derrick@lge.com>
    Tested-by: Keith Derrick <keith.derrick@lge.com>
    Reviewed-by: Sapna Todwal <sapna.todwal@lge.com>
    Reviewed-by: Ameya Palande <ameya.palande@lge.com>
  2. @kdopen

    Eliminate possible buffer overrun

    kdopen authored
    :Release Notes:
    Corrected a potential buffer overflow detected by coverity.
    
    :Detailed Notes:
    nyx_utils_write_value was using a buffer which was too small to hold the
    maximum length string plus the terminating nul, leading to a potential
    buffer overflow.
    
    The buffer size was doubled to ensure it could hold any possible value,
    snprintf is used instead of sprintf, the provided length always leaves
    room for the addition of a terminating nul, and a nul is added to ensure
    that a truncated conversion is always terminated.
    
    A similar set of changes were made to nyx_utils_read_value, to ensure
    that a truncated read is always nul-terminated.
    
    :Testing Performed:
    Clean compile and verification by inspection
    
    :QA Notes:
    
    :Issues Addressed:
    [GF-37400] nyx-lib: Coverity Issue
    
    Open-webOS-DCO-1.0-Signed-off-by: Keith Derrick <keith.derrick@lge.com>
    
    Change-Id: I62485d0bc017fefc8e17e1fdc605411641ac41da
    Reviewed-on: https://g2g.palm.com/3396
    Reviewed-by: Build Verification
    Reviewed-by: Keith Derrick <keith.derrick@lge.com>
    Tested-by: Keith Derrick <keith.derrick@lge.com>
    Reviewed-by: Ameya Palande <ameya.palande@lge.com>
    Reviewed-by: Sapna Todwal <sapna.todwal@lge.com>
Commits on Aug 26, 2013
  1. @kdopen

    Add Manufacturing Version Query to OSInfo module

    kdopen authored
    :Release Notes:
    The OSInfo interface now provides the NYX_OS_INFO_MANUFACTURING_VERSION
    query enumeration value for modules to implement.
    
    :Detailed Notes:
    Added NYX_OS_INFO_MANUFACTURING_VERSION to the list of operating system
    values which can be queried.
    
    This takes nyx-lib to version 5.2.0 .
    
    Also refactored a utility routine to suppress an "unused-result" warning
    and eliminate an inelegant 'goto'.
    
    :Testing Performed:
    Compiled and tested on desktop and emulator.
    
    :QA Notes:
    
    :Issues Addressed:
    [GF-12714] Supply a "manufacturing version" for webOS
    [GF-13442] nyx-lib: Add NYX_OS_INFO_MANUFACTURING_VERSION query to
               OSInfo
    
    Open-webOS-DCO-1.0-Signed-off-by: Keith Derrick <keith.derrick@lge.com>
    Change-Id: I411edd2ac1b325ab7d50b509651501640030f805
    Reviewed-on: https://g2g.palm.com/3168
    Reviewed-by: Build Verification
    Reviewed-by: Herb Kuta <herb.kuta@lge.com>
    Reviewed-by: Keith Derrick <keith.derrick@lge.com>
    Tested-by: Keith Derrick <keith.derrick@lge.com>
Commits on Jul 10, 2013
  1. @maksym-shevchenko-owo @kdopen

    Assign Copyright to LG Electronics, Inc.

    maksym-shevchenko-owo authored kdopen committed
    [GF-5644] Convert HP Copyright to LG
    
    Open-webOS-DCO-1.0-Signed-off-by: Maksym Shevchenko <myshevchenko@luxoft.com>
    
    Change-Id: I6f6647a49dd7873c7ad4f6a496b32914ae00de95
    Reviewed-on: https://g2g.palm.com/2585
    Reviewed-by: Build Verification
    Reviewed-by: Keith Derrick <keith.derrick@lge.com>
    Tested-by: Keith Derrick <keith.derrick@lge.com>
Commits on Apr 17, 2013
  1. @pekkaropo-owo

    Rename NYX_OS_INFO_WEBOS_BUILD to NYX_OS_INFO_WEBOS_BUILD_ID

    pekkaropo-owo authored
    - Add NYX_OS_INFO_WEBOS_BUILD_ID as an alias to NYX_OS_INFO_WEBOS_BUILD
    - Mark NYX_OS_INFO_WEBOS_BUILD as 'deprecated'
    
    [GF-3283] nyx-lib: Rename NYX_OS_INFO_WEBOS_BUILD to NYX_OS_INFO_WEBOS_BUILD_ID
    
    Open-webOS-DCO-1.0-Signed-off-by: Pekka Ropo <pekka.ropo@palm.com>
    
    Change-Id: Ia4a33894deed81a2d8a47c19e8fa30580b919f02
Commits on Apr 12, 2013
  1. Improve documentation of nyx_device_info_type_t

    Herb Kuta authored
    - Document which nyx_device_info_type_t queries are constant
    - Add documentation for some other enumerants
    - "doxygenize" the existing enumerant documentaion
    
    [GF-2811] Remove non-constant fields from device_info.json
    
    Open-webOS-DCO-1.0-Signed-off-by: Herb Kuta <herb.kuta@lge.com>
    Open-webOS-DCO-1.0-Signed-off-by: Keith Derrick <keith.derrick@lge.com>
    Change-Id: I8e33b65e3847a0e921f3f3d9d8765c5caffb8a96
Commits on Apr 4, 2013
  1. @pekkaropo-owo

    Add new method to DeviceInfo device type

    pekkaropo-owo authored
    - Add 'nyx_device_info_query' method to query device information
    - Deprecate 'nyx_device_info_get_info' method
    - Improve API documentation on DeviceInfo and OSInfo device types
    - Set version to 5.1.0
    
    [GF-2647] nyx-lib: Add "modern" query routine to device_info device type API
    
    Open-webOS-DCO-1.0-Signed-off-by: Pekka Ropo <pekka.ropo@palm.com>
    
    Change-Id: Ia49626851e9edc259896afbaeb72bc77a963a2a9
Commits on Mar 15, 2013
  1. @kdopen

    Remove unused boundary enums

    kdopen authored
    The symbols for the first and last values in the NYX_DEVICE_*,
    NYX_DEVICE_INFO_* and NYX_OS_INFO_* enumerations were meant to
    enable clients to iterate over the range of legal values. Instead
    they simply caused an ABI break everytime a new value was added,
    and were never used.
    
    Therefore, they have been removed.
    
    [GF-2451] Remove all iterator boundary values from ENUM's in API
    
    Open-webOS-DCO-1.0-Signed-off-by: Keith Derrick <keith.derrick@lge.com>
    
    Change-Id: I69d3cfc4fcf4a30d24e1f5c6a8093bb1f35f3f66
  2. @kdopen

    Major version 5.0

    kdopen authored
    - Add OS Information API
    - Add security API
    
    Open-webOS-DCO-1.0-Signed-off-by: Keith Derrick <keith.derrick@lge.com>
    
    Change-Id: I8d70c408d7163cdbd0202d48f44cd5ef5d980e91
  3. @kdopen

    Add security API

    Janne Kiiski authored kdopen committed
    Open-webOS-DCO-1.0-Signed-off-by: Janne Kiiski <janne.kiiski@palm.com>
    Open-webOS-DCO-1.0-Signed-off-by: Keith Derrick <keith.derrick@lge.com>
    
    Conflicts:
    
    	include/public/nyx/common/nyx_device.h
    	include/public/nyx/module/nyx_device_internal.h
    	src/core/nyx_core_impl.c
    
    Change-Id: Id58df1b81b320f60becaaba1463ba5ee633094c5
  4. @juhanimesiainen-owo @kdopen

    Add API for OSInfo device type

    juhanimesiainen-owo authored kdopen committed
    [GF-2433] Add Nyx device type to return OS info
    
    Open-webOS-DCO-1.0-Signed-off-by: Juhani Mesiainen <juhani.mesiainen@palm.com>
    Open-webOS-DCO-1.0-Signed-off-by: Pekka Ropo <pekka.ropo@palm.com>
    Open-webOS-DCO-1.0-Signed-off-by: Keith Derrick <keith.derrick@lge.com>
    
    Change-Id: I81f819b906c6d60da66fc59b6d8976a9217656a4
Commits on Feb 21, 2013
  1. Fix nyx_device_close memory deallocations

    Janne Kiiski authored
    - free name and description using g_free (allocated using g_strndup)
    - cleanup logic by caching whole nyx_device struct instead of
      picking individual members
    
    Open-webOS-DCO-1.0-Signed-off-by: Janne Kiiski <janne.kiiski@palm.com>
    
    Change-Id: I9ce32cd8dd80daf93f260cd54aabe7df58835196
Commits on Feb 20, 2013
  1. Do not dereference nyx_device struct after closing module

    Janne Kiiski authored
    nyx_module_close (close_ptr) function releases the memory of nyx_device (d),
    so do not dereference/touch that dangling pointer after close
    
    Open-webOS-DCO-1.0-Signed-off-by: Janne Kiiski <janne.kiiski@palm.com>
    
    Change-Id: I1511d2ea2fe6dc3694348e2f5af97fdeb8033174
Commits on Jan 14, 2013
  1. @pekkaropo-owo

    Remove nyx_device_info_device_t from nyx-lib

    pekkaropo-owo authored
    - Add NYX_DEVICE_INFO_HARDWARE_ID into nyx_device_info_type_t to enable getting
      hardware ID using nyx_device_info_get_info
    - Remove nyx_device_info_get_hardware_id function
    - Update nyx-lib version to 4.0.0~rc1
    
    Open-webOS-DCO-1.0-Signed-off-by: Pekka Ropo <pekka.ropo@palm.com>
    
    Change-Id: Ie86806f6a0c2844bd6b405b7d4e49b75afde7ebc
Commits on Jan 8, 2013
  1. @pekkaropo-owo

    Fix a typo in nyx_device.h

    pekkaropo-owo authored
    Open-webOS-DCO-1.0-Signed-off-by: Pekka Ropo <pekka.ropo@palm.com>
    
    Change-Id: I14ee3012d440e9854ef877c8f23b83b0cd788d13
  2. @pekkaropo-owo

    Add Mass Storage Mode device

    pekkaropo-owo authored
    - Increment version number to 3.2.0~rc1
    - Move all Mass Storage Mode related functionality from System device to a new device
    
    Open-webOS-DCO-1.0-Signed-off-by: Pekka Ropo <pekka.ropo@palm.com>
    
    Change-Id: I29e0fb843650cf60999b698829334c44cd053904
Commits on Dec 13, 2012
  1. Add nyx_cmd_module_dir variable to nyx.pc

    Keith Derrick authored
    Adds a pkgconfig variable for the root of the directory tree into which
    modules for nyx-cmd are installed.
    
    Open-webOS-DCO-1.0-Signed-off-by: Keith Derrick <keith.derrick@palm.com>
    
    Change-Id: I35edfc990bb2e695be629be8650552595e232229
Commits on Nov 3, 2012
  1. Add 'reason" code to nyx_system_shutdown

    Keith Derrick authored
    - Make API's for shutdown and reboot consistent
    - Also clean up some documentation
    
    Open-webOS-DCO-1.0-Signed-off-by: Keith Derrick <keith.derrick@palm.com>
    
    Change-Id: Ic052f5d187caaaab08767587fa44b21f8d9ad620
Commits on Nov 2, 2012
  1. Remove product-specific fields from device info

    Keith Derrick authored
    The following fields have been removed from the nyx_device_info interface
    as they should be reconfigurable without requiring a different build:
    
      NYX_DEVICE_INFO_CARRIER
      NYX_DEVICE_INFO_DM_*
      NYX_DEVICE_INFO_PART_NUMBER
      NYX_DEVICE_INFO_PRODUCT_SKU
      NYX_DEVICE_INFO_PRODUCTION_NAME
      NYX_DEVICE_INFO_PRODUCT_NAME_SHORT
      NYX_DEVICE_INFO_PRODUCT_NAME_BRANDED
    
    Open-webOS-DCO-1.0-Signed-off-by: Sapna Todwal <sapna.todwal@palm.com>
    Open-webOS-DCO-1.0-Signed-off-by: Keith Derrick <keith.derrick@palm.com>
    
    Change-Id: I75ea4da92fe816daae3c2a0e5b11b21b197670c5
  2. @jannehurskainen-owo

    Add reason argument for nyx_system_reboot

    jannehurskainen-owo authored Keith Derrick committed
    Extended the API because in some cases we need to reboot to
    bootloader, and this reason argument will tell bootloader why the
    reboot happened
    
    Open-webOS-DCO-1.0-Signed-off-by: Janne Hurskainen <janne.hurskainen@palm.com>
    Open-webOS-DCO-1.0-Signed-off-by: Keith Derrick <keith.derrick@palm.com>
    
    Change-Id: I389a6a04bf89696e510f59c222dafc3fb32581dc
Commits on Oct 10, 2012
  1. Revert "Add additional enums in nyx_device_info_type_t"

    Sapna Todwal authored Gerrit Code Review committed
    This reverts commit 00a2e05
Commits on Oct 9, 2012
  1. Add additional enums in nyx_device_info_type_t

    Sapna Todwal authored
    Open-webOS-DCO-1.0-Signed-off-by: Sapna Todwal <sapna.todwal@palm.com>
    
    Change-Id: Id6b017f04f8b2ad693119a462128f537ef03b592
Commits on Oct 8, 2012
  1. Add 'nyx_module_prefix' and 'nyx_module_suffix' variables to nyx.pc

    Sapna Todwal authored
    Open-webOS-DCO-1.0-Signed-off-by: Sapna Todwal <sapna.todwal@palm.com>
    
    Change-Id: I82269f42f825049bbcfff2b7c2bc5a4fc18b92c9
  2. Add corrections to README.md and comments in CMakeLists.txt

    Sapna Todwal authored
    Open-webOS-DCO-1.0-Signed-off-by: Sapna Todwal <sapna.todwal@palm.com>
    
    Change-Id: Iec1ffdb3e43aeaa16001503f22e1e48c25283574
Commits on Oct 4, 2012
  1. Convert to use cmake-modules-webos

    Sapna Todwal authored
    Open-webOS-DCO-1.0-Signed-off-by: Sapna Todwal <sapna.todwal@palm.com>
    
    Change-Id: I610ff756a4821ff830c313058bd4a10a01b3271c
  2. Move files in doc folder to follow cmake-modules-webos format

    Sapna Todwal authored
    Open-webOS-DCO-1.0-Signed-off-by: Sapna Todwal <sapna.todwal@palm.com>
    
    Change-Id: I3d938414eca869edb52a616bb823341c37ec1c14
Commits on Oct 2, 2012
  1. Move files as per recommended source layout

    Sapna Todwal authored
    - Move include files under include/public
    - Move nyx.pc.in file into files/pkgconfig
    - Move nyx_version.h.in file in include folder.
    - Move src/doc files into doc
    - Remove extra CMakeLists.txt files
    - WARNING: No content changes; a subsequent commit is required in order
    for this component to be buildable.
    
    Open-webOS-DCO-1.0-Signed-off-by: Sapna Todwal <sapna.todwal@palm.com>
    
    Change-Id: Ib82bb78ebf904b99d5bc28616fb3a6817fca8546
Commits on Aug 31, 2012
  1. Correct the license block in README.md

    Richard Kwan authored
    Change-Id: I6dc1ed361da859373991f969f4ca946b0032139f
Commits on Aug 5, 2012
  1. @DrWEbOS

    Correct the handling of null method_hash_table pointers

    DrWEbOS authored Gerrit Code Review committed
    Change-Id: I4a5e5a3e7d0f0320ddd7eab3125e64a1b794dbc6
Commits on Jul 26, 2012
  1. Tidy up README file

    Keith Derrick authored
    - Reformat lines to about 80 characters
    - Change webOS to Open webOS
    
    Change-Id: I0915cef7e4b0caa36fdb5b334fc80a197beee18f
Commits on Jul 25, 2012
  1. Correct description in .pc file

    Keith Derrick authored
    Change-Id: Ia5c2ad1a698cdbb686d9bacc57fe7d76944d6509
    Reviewed-on: http://g2g.palm.com/2
    Reviewed-by: Keith Derrick <keith.derrick@palm.com>
    Tested-by: Keith Derrick <keith.derrick@palm.com>
Commits on Jul 11, 2012
  1. @goWebos

    Use FindPkgConfig for GLIB2; Remove FindGlib2 and LibFindMacros cmake…

    goWebos authored Keith Derrick committed
    … modules.
Something went wrong with that request. Please try again.