Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Commits on Oct 3, 2013
  1. @kdopen

    Remove parameter from nyx_system_erase_partition()

    kdopen authored
    :Release Notes:
    The nyx_system_erase_partition method API has changed to avoid buffer
    overflow errors.
    This API change takes nyx-lib (and it's modules) to v6.0.0
    :Detailed Notes:
    The nyx_system_erase_partition method had an "error message" parameter
    of type `char *`. The original intent was to return an error message
    through the pointer. However, without a buffer length parameter, there
    is simply no safe way to implement that.
    Alternatives were to either change it a 'char **' and return a
    dynamically allocated buffer (which raises the possibility of memory
    leaks), add a buffer length parameter (which seems a bit unnecessary
    overhead for an unlikley error condition), or simply delete the
    parameter from the API.
    As the method already has an error code return value, the third option
    was taken.
    Additionally, a new erase type (NYX_SYSTEM_ERASE_DEVELOPER) was added.
    :Testing Performed:
    Currently, nothing is using this method, so the only testing required
    is clean compilation.
    :QA Notes:
    :Issues Addressed:
    [GF-37730] Provide implementation of Nyx System module to support
               factory reset
    Open-webOS-DCO-1.0-Signed-off-by: Keith Derrick <>
    Change-Id: I34bd7107b9945a18f1511c2cabe07da1f25be377
    Reviewed-by: Build Verification
    Reviewed-by: Keith Derrick <>
    Tested-by: Keith Derrick <>
Commits on Sep 19, 2013
  1. @kdopen

    Cosmetic change to apply code formatting

    kdopen authored
    :Release Notes:
    All source code is now formatted in a consistent manner, including
    applying the tabs to indent, spaces to align convention.
    :Detailed Notes:
    The code formatting program 'Artistic Style' was used to clean up
    any inconsistent formatting prior to making subsequent changes in
    the code.
    The applied options are available in the new file 'astyle_options'.
    :Testing Performed:
    - Checked output of git diff -w -b --ignore-blank-lines
    - Check component still compiles
    - With 'ignore whitespace=all' set, scrubbed gerrit code review
    :QA Notes:
    :Issues Addressed:
    [GF-36641] Apply Artistic Style with standard options to nyx-lib
    Open-webOS-DCO-1.0-Signed-off-by: Keith Derrick <>
    Change-Id: I680df4ea9e1e4eb564cc9d38630e8adae3a9af6d
    Reviewed-by: Build Verification
    Reviewed-by: Keith Derrick <>
    Tested-by: Keith Derrick <>
    Reviewed-by: Sapna Todwal <>
    Reviewed-by: Ameya Palande <>
  2. @kdopen

    Eliminate possible buffer overrun

    kdopen authored
    :Release Notes:
    Corrected a potential buffer overflow detected by coverity.
    :Detailed Notes:
    nyx_utils_write_value was using a buffer which was too small to hold the
    maximum length string plus the terminating nul, leading to a potential
    buffer overflow.
    The buffer size was doubled to ensure it could hold any possible value,
    snprintf is used instead of sprintf, the provided length always leaves
    room for the addition of a terminating nul, and a nul is added to ensure
    that a truncated conversion is always terminated.
    A similar set of changes were made to nyx_utils_read_value, to ensure
    that a truncated read is always nul-terminated.
    :Testing Performed:
    Clean compile and verification by inspection
    :QA Notes:
    :Issues Addressed:
    [GF-37400] nyx-lib: Coverity Issue
    Open-webOS-DCO-1.0-Signed-off-by: Keith Derrick <>
    Change-Id: I62485d0bc017fefc8e17e1fdc605411641ac41da
    Reviewed-by: Build Verification
    Reviewed-by: Keith Derrick <>
    Tested-by: Keith Derrick <>
    Reviewed-by: Ameya Palande <>
    Reviewed-by: Sapna Todwal <>
Commits on Aug 26, 2013
  1. @kdopen

    Add Manufacturing Version Query to OSInfo module

    kdopen authored
    :Release Notes:
    The OSInfo interface now provides the NYX_OS_INFO_MANUFACTURING_VERSION
    query enumeration value for modules to implement.
    :Detailed Notes:
    Added NYX_OS_INFO_MANUFACTURING_VERSION to the list of operating system
    values which can be queried.
    This takes nyx-lib to version 5.2.0 .
    Also refactored a utility routine to suppress an "unused-result" warning
    and eliminate an inelegant 'goto'.
    :Testing Performed:
    Compiled and tested on desktop and emulator.
    :QA Notes:
    :Issues Addressed:
    [GF-12714] Supply a "manufacturing version" for webOS
    [GF-13442] nyx-lib: Add NYX_OS_INFO_MANUFACTURING_VERSION query to
    Open-webOS-DCO-1.0-Signed-off-by: Keith Derrick <>
    Change-Id: I411edd2ac1b325ab7d50b509651501640030f805
    Reviewed-by: Build Verification
    Reviewed-by: Herb Kuta <>
    Reviewed-by: Keith Derrick <>
    Tested-by: Keith Derrick <>
Commits on Jul 10, 2013
  1. @maksym-shevchenko-owo @kdopen

    Assign Copyright to LG Electronics, Inc.

    maksym-shevchenko-owo authored kdopen committed
    [GF-5644] Convert HP Copyright to LG
    Open-webOS-DCO-1.0-Signed-off-by: Maksym Shevchenko <>
    Change-Id: I6f6647a49dd7873c7ad4f6a496b32914ae00de95
    Reviewed-by: Build Verification
    Reviewed-by: Keith Derrick <>
    Tested-by: Keith Derrick <>
Commits on Apr 4, 2013
  1. @pekkaropo-owo

    Add new method to DeviceInfo device type

    pekkaropo-owo authored
    - Add 'nyx_device_info_query' method to query device information
    - Deprecate 'nyx_device_info_get_info' method
    - Improve API documentation on DeviceInfo and OSInfo device types
    - Set version to 5.1.0
    [GF-2647] nyx-lib: Add "modern" query routine to device_info device type API
    Open-webOS-DCO-1.0-Signed-off-by: Pekka Ropo <>
    Change-Id: Ia49626851e9edc259896afbaeb72bc77a963a2a9
Commits on Mar 15, 2013
  1. @kdopen

    Add security API

    Janne Kiiski authored kdopen committed
    Open-webOS-DCO-1.0-Signed-off-by: Janne Kiiski <>
    Open-webOS-DCO-1.0-Signed-off-by: Keith Derrick <>
    Change-Id: Id58df1b81b320f60becaaba1463ba5ee633094c5
  2. @juhanimesiainen-owo @kdopen

    Add API for OSInfo device type

    juhanimesiainen-owo authored kdopen committed
    [GF-2433] Add Nyx device type to return OS info
    Open-webOS-DCO-1.0-Signed-off-by: Juhani Mesiainen <>
    Open-webOS-DCO-1.0-Signed-off-by: Pekka Ropo <>
    Open-webOS-DCO-1.0-Signed-off-by: Keith Derrick <>
    Change-Id: I81f819b906c6d60da66fc59b6d8976a9217656a4
Commits on Feb 21, 2013
  1. Fix nyx_device_close memory deallocations

    Janne Kiiski authored
    - free name and description using g_free (allocated using g_strndup)
    - cleanup logic by caching whole nyx_device struct instead of
      picking individual members
    Open-webOS-DCO-1.0-Signed-off-by: Janne Kiiski <>
    Change-Id: I9ce32cd8dd80daf93f260cd54aabe7df58835196
Commits on Feb 20, 2013
  1. Do not dereference nyx_device struct after closing module

    Janne Kiiski authored
    nyx_module_close (close_ptr) function releases the memory of nyx_device (d),
    so do not dereference/touch that dangling pointer after close
    Open-webOS-DCO-1.0-Signed-off-by: Janne Kiiski <>
    Change-Id: I1511d2ea2fe6dc3694348e2f5af97fdeb8033174
Commits on Jan 14, 2013
  1. @pekkaropo-owo

    Remove nyx_device_info_device_t from nyx-lib

    pekkaropo-owo authored
    - Add NYX_DEVICE_INFO_HARDWARE_ID into nyx_device_info_type_t to enable getting
      hardware ID using nyx_device_info_get_info
    - Remove nyx_device_info_get_hardware_id function
    - Update nyx-lib version to 4.0.0~rc1
    Open-webOS-DCO-1.0-Signed-off-by: Pekka Ropo <>
    Change-Id: Ie86806f6a0c2844bd6b405b7d4e49b75afde7ebc
Commits on Jan 8, 2013
  1. @pekkaropo-owo

    Add Mass Storage Mode device

    pekkaropo-owo authored
    - Increment version number to 3.2.0~rc1
    - Move all Mass Storage Mode related functionality from System device to a new device
    Open-webOS-DCO-1.0-Signed-off-by: Pekka Ropo <>
    Change-Id: I29e0fb843650cf60999b698829334c44cd053904
Commits on Nov 3, 2012
  1. Add 'reason" code to nyx_system_shutdown

    Keith Derrick authored
    - Make API's for shutdown and reboot consistent
    - Also clean up some documentation
    Open-webOS-DCO-1.0-Signed-off-by: Keith Derrick <>
    Change-Id: Ic052f5d187caaaab08767587fa44b21f8d9ad620
Commits on Nov 2, 2012
  1. @jannehurskainen-owo

    Add reason argument for nyx_system_reboot

    jannehurskainen-owo authored Keith Derrick committed
    Extended the API because in some cases we need to reboot to
    bootloader, and this reason argument will tell bootloader why the
    reboot happened
    Open-webOS-DCO-1.0-Signed-off-by: Janne Hurskainen <>
    Open-webOS-DCO-1.0-Signed-off-by: Keith Derrick <>
    Change-Id: I389a6a04bf89696e510f59c222dafc3fb32581dc
Commits on Oct 4, 2012
  1. Convert to use cmake-modules-webos

    Sapna Todwal authored
    Open-webOS-DCO-1.0-Signed-off-by: Sapna Todwal <>
    Change-Id: I610ff756a4821ff830c313058bd4a10a01b3271c
Commits on Oct 2, 2012
  1. Move files as per recommended source layout

    Sapna Todwal authored
    - Move include files under include/public
    - Move file into files/pkgconfig
    - Move file in include folder.
    - Move src/doc files into doc
    - Remove extra CMakeLists.txt files
    - WARNING: No content changes; a subsequent commit is required in order
    for this component to be buildable.
    Open-webOS-DCO-1.0-Signed-off-by: Sapna Todwal <>
    Change-Id: Ib82bb78ebf904b99d5bc28616fb3a6817fca8546
Commits on Aug 5, 2012
  1. @DrWEbOS

    Correct the handling of null method_hash_table pointers

    DrWEbOS authored Gerrit Code Review committed
    Change-Id: I4a5e5a3e7d0f0320ddd7eab3125e64a1b794dbc6
Commits on Jul 25, 2012
  1. Correct description in .pc file

    Keith Derrick authored
    Change-Id: Ia5c2ad1a698cdbb686d9bacc57fe7d76944d6509
    Reviewed-by: Keith Derrick <>
    Tested-by: Keith Derrick <>
Commits on Jul 11, 2012
  1. @goWebos

    Use FindPkgConfig for GLIB2; Remove FindGlib2 and LibFindMacros cmake…

    goWebos authored Keith Derrick committed
    … modules.
Commits on Jun 8, 2012
  1. Merge pull request #50 from nyx-project/autoconfigure_and_split_docum…

    Keith Derrick authored
    Configure and Reorganize Documentation Generation
Commits on Apr 20, 2012
  1. Cleanup of core implementation and headers

    Keith Derrick authored
    - nyx_core.h
    -- Remove unused include of stdbool.h
    -- Add NYX_API_EXPORT qualifier to all functions (needs nyx_macros.h)
    -- Corrected prototype for nyx_get_api_version_maor() - name was wrong
    -- Added some descriptive comments for the API documentation.
    - nyx_impl.c, nyx_core_impl.[ch]
    -- Removed all reference and support for Glib style main loops and
       pthreads. (nyx_async still requires pthreads)
    - Other files: Fixed miscellaneous typo's in documentation
Commits on Apr 19, 2012
  1. Configure and Reorganize Documentation Generation

    Keith Derrick authored
    - Use configure_file() to configure the project name, version, and
    paths in the doxygen input files.
    - Add a make target for docs, allowing to be deleted.
    - Move doxygen input files under the src directory and add
    CMakeLists.txt to configure them,
    - Remove the contents of the original doc directory.
    - Modify the README file with new instructions for generating docs.
    - Add a README_FIRST to src/doc to cover the possibility that doxywizard
    or some other tool may strip the license information from the files.
    - Split the generated documentation to reflect the different client and
    module APIs.
    - In keeping with supporting out-of-tree builds, documentation is generated
    under doc/ in the build directory. But the user can override this on the
    cmake command line.
    - Updated the .gitignore file with a license block, and modified the list of
    files - including other variants for the build directory name and the
    original doc/ directory in the project root.
    - Note the prepending of a "/" to directory names in .gitignore. This
    stops the directories being ignored in subdirectories. Ignoring /doc
    in the root also ignored /src/doc!
Commits on Apr 18, 2012
  1. Move CMakeLists.txt to root directory

    Keith Derrick authored Damian Kowalewski committed
    -Creates a new CMakeLists.txt file in the repository root which
    then invokes the original in ./src
    -Modifies CMakeLists.txt and lib.cmake in the src directory so
    that they use CMAKE_CURRENT_SOURCE_DIR instead of CMAKE_SOURCE_DIR
    when referring to subdirectories in the source tree.
Commits on Apr 17, 2012
  1. Make set function parameters const correct

    Keith Derrick authored Damian Kowalewski committed
    The following methods
    take pointers as their parameter. These need to be const pointers
    to make the contract (that the methods will not write through them)
Commits on Apr 12, 2012
  1. Merge remote branch 'origin/Fix-Incorrect-De-macroization-2'

    Damian Kowalewski authored
Commits on Apr 11, 2012
  1. Fix incorrect de-macro-ization in keys

    Gayathri Srinivasan authored
Commits on Apr 6, 2012
  1. Add _function to all function pointer typedef names where it doesn't …

    Gayathri Srinivasan authored
Commits on Apr 2, 2012
  1. Modify the variable 'nyx_device_callback' typedef to 'nyx_device_call…

    Gayathri Srinivasan authored
    …back_function_t' to indicate it is a typedef for function pointer
Commits on Mar 30, 2012
  1. Merge remote branch 'origin/Fix-pointer-assignment'

    Damian Kowalewski authored
  2. Merge remote branch 'origin/Header-file-inclusion'

    Damian Kowalewski authored
  3. Fixed incompatible pointer type assignment

    Gayathri Srinivasan authored
Commits on Mar 29, 2012
  1. Fix for 'Implicit declaration of strtol()' warning

    Gayathri Srinivasan authored
  2. Splitting nyx_set_rate_t into nyx_set_report_rate_t and nyx_set_scan_…

    Gayathri Srinivasan authored
    …rate_t to have client API definition consistent with module mapping. Similar changes for nyx_get_rate_t
Commits on Mar 27, 2012
  1. - Matching firmware update API parameter in nyx_device_internal.h wit…

    Gayathri Srinivasan authored
    …h client API - fix for issue#7
    - Correcting definition of nyx_firmware_version_info_t - Fix for issue#25
  2. @kuta42

    Simplify the CMake listfiles

    kuta42 authored
    Remove the add_nyx_libs() and nyx_include() macros from nyx.cmake and
    simplify add_nyx_source(). Their previous complexity is no longer
    necessary now that the repository has been split. Eliminate the verbose
    outputting of the lists of source files.
Something went wrong with that request. Please try again.