Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.10 bugfixes #188

Merged
merged 7 commits into from Dec 26, 2014
Merged

2.10 bugfixes #188

merged 7 commits into from Dec 26, 2014

Conversation

goehle
Copy link
Member

@goehle goehle commented Dec 22, 2014

Changed parsePopUp so that it prints a list of options on a hardcopy. (Its not functional of course, but at least people can see what they would have been able to choose.)

@dpvc
Copy link
Member

dpvc commented Dec 23, 2014

Note that this may change the formatting of the paragraphs. If the pop-up is part of a sentence, (like "the value A is (greater/less) than the value B", you will end up with

The value A is

   * greater
   * less

than the value B.

I'm not sure this is optimal. It might be better to use something like [A/B/C] if the options are short enough (and don't contain / or ]), and the itemized lists if they are long.

…aren't too many of them and if they aren't too long.
@goehle
Copy link
Member Author

goehle commented Dec 23, 2014

I changed it so that it prints inline as suggested when there are no more than 3 options with a total of less than 25 characters and no /,[ or].

Edit: Limiting the number of options and number of characters is wierd so I changed it to just limit the number of characters.

# if the total number of characters is not more than
# 30 and not containing / or ] then we print out
# the select as a string: [A/B/C]
if (length(join('',@$list)) < 25 &&
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment says 30 characters, but the count is 25. Is that to compensate for the brackets and slashes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

30 was too long in practice so I shortened it a bit. I'll recon the
comment too :)

On Tue, Dec 23, 2014 at 10:54 AM, Davide P. Cervone <
notifications@github.com> wrote:

In macros/parserPopUp.pl
#188 (diff):

@@ -119,7 +119,21 @@ sub MENU {
};
$menu .= "";
} elsif ($main::displayMode eq "TeX") {

  • $menu = "\fbox{?}";
  •  # if the total number of characters is not more than
    
  •  # 30 and not containing / or ] then we print out
    
  •  # the select as a string: [A/B/C]
    
  •  if (length(join('',@$list)) < 25 &&
    

The comment says 30 characters, but the count is 25. Is that to compensate
for the brackets and slashes?


Reply to this email directly or view it on GitHub
https://github.com/openwebwork/pg/pull/188/files#r22220248.

goehle added a commit that referenced this pull request Dec 26, 2014
@goehle goehle merged commit 6fce3c5 into openwebwork:release/2.10 Dec 26, 2014
@goehle goehle deleted the 2.10-bugfixes branch July 15, 2016 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants