-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PG-2.15 #408
Conversation
…esn't interfere with utf8
Update the definition of parsec to include more accuracy -- it still doesn't pass the test_units.t file. The definition of steradian is still iffy.
…evelop_test_units
…sing statements to see the next error.
This can be used to test utf8 coverage as well as the template math4_ar which has right justification and is a preliminary stab at creating a template suitable for arabic PG problems.
create records in PG->{flags} with settings which will influence the HTML lang and dir attributes set for the HTML element containing the problem. This allows proper detection of the language of the problem in the browser, when it is not the primary course language, and to override the direction for cases when a LTR problem is being viewed/assigned in a course in a RTL course, or visa-versa. The flag values set in the problem are processed in the subroutine output_problem_lang_and_dir() in webwork2/lib/WeBWorK/ContentGenerator/Problem.pm if there is no override set in the course configuration.
set flags for the problem language and textdirection which can be accessed inside the webwork2 code to allow using this data to set the HTML lang and dir tags as needed on DIV elements which envelop the problem text.
Develop utf8 ver2
…_flags Add lang and direction to pg flags
Rel pg 2.14
Rel pg 2.14 -- fix one bug and update copyright
…e Encoding.pm file
Develop unit tests2
…rough Real to string conversion).
…ngs like stretchy braces can be added around answer rules even if not in array form)
patches #422, after we found that using `\r` as the verbatim delimiter all the time was not workable given how browsers treat `\r`.
Disable autocorrect, autocapitalize, autocomplete, and spellcheck on text inputs
differentiate verbatim delimiter selection
…who depend on a screen reader. TeX output remains plain bold.
CSS files from webwork2/htdocs/css/ in the HTML generate for this problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have been using the WW 2.15 and PG 2.15 (and slightly earlier versions of the code with UTF-8 support) in production for about 6 months. Overall, it works fine.
Several people have tested and remarked at: http://webwork.maa.org/moodle/mod/forum/discuss.php?d=4623
I just made several small PRs to the branch:
- HTML output to use <STRONG> instead of <B> for BBOLD #426
- Add $BKBD and $EKBD #427
- Add an ADD_CSS_FILE() method #428
and @mgage has a small fix in: - Fix errors caused by bad merge of tableau.pl #425
Other than #425 which fixes a bug by a sloppy commit or merge, the rest is just "nice to have". If some of the other PRs are not merged soon they can be targeted to develop once all the recent code is merged into develop.
I think we are essentially ready to release PG 2.15 and WW 2.15.
Note: The minor merge conflict is easy to handle. |
HTML output to use <STRONG> instead of <B> for BBOLD
Fix errors caused by bad merge of tableau.pl
TeX and PreTeXt output, and using the HTML <KBD> tag for HTML output. No effort was made to allow the use of special characters inside the unit of content, so it should be used with care.
Add $BKBD and $EKBD
Add an ADD_CSS_FILE() method
Unless anyone has any additional urgent changes or objections - I think PG 2.15 is ready for release. |
This pull request could certainly wait until 2.16. There is no urgency for it to go into 2.15. |
As far as I can tell there are no pending PRs or major issues for either pg or webwork2 remaining to hold off the release of 2.15. The following "minor" issues may need to be addressed with hotfixes: |
(remove !!beta)
Update VERSION file
This is a version containing multilingual features (utf8 4 byte characters). There are database changes so test cautiously (backup up the database just in case). If $ENABLE_UTF8MB4=0 you should be able to use this on existing sites, even with mysql databases earlier than 5.3. If you set $ENABLE_UTF8MB4=1 then you will get a "wide character" error message from the database if it is too old. If it is new enough you will be able to use all characters including Chinese, emoji, Arabic and so forth. (Download the companion WeBWorK-2.15-beta as well.)