Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PG-2.15 #408

Merged
merged 176 commits into from
Oct 6, 2019
Merged

PG-2.15 #408

merged 176 commits into from
Oct 6, 2019

Conversation

mgage
Copy link
Sponsor Member

@mgage mgage commented May 25, 2019

This is a version containing multilingual features (utf8 4 byte characters). There are database changes so test cautiously (backup up the database just in case). If $ENABLE_UTF8MB4=0 you should be able to use this on existing sites, even with mysql databases earlier than 5.3. If you set $ENABLE_UTF8MB4=1 then you will get a "wide character" error message from the database if it is too old. If it is new enough you will be able to use all characters including Chinese, emoji, Arabic and so forth. (Download the companion WeBWorK-2.15-beta as well.)

goehle and others added 30 commits June 20, 2016 20:57
Update the definition of parsec to include more accuracy -- it still doesn't pass the test_units.t  file.

The definition of steradian is still iffy.
This can be used to test utf8 coverage as well as
the template math4_ar  which has right justification and is a preliminary
stab at creating a template suitable for arabic PG problems.
create records in PG->{flags} with settings which will influence the
HTML lang and dir attributes set for the HTML element containing the
problem. This allows proper detection of the language of the problem in
the browser, when it is not the primary course language, and to override
the direction for cases when a LTR problem is being viewed/assigned in a
course in a RTL course, or visa-versa. The flag values set in the problem
are processed in the subroutine output_problem_lang_and_dir() in
	webwork2/lib/WeBWorK/ContentGenerator/Problem.pm
if there is no override set in the course configuration.
set flags for the problem language and textdirection which can be accessed
inside the webwork2 code to allow using this data to set the HTML lang and
dir tags as needed on DIV elements which envelop the problem text.
…_flags

Add lang and direction to pg flags
Rel pg 2.14 -- fix one bug and update copyright
…ngs like stretchy braces can be added around answer rules even if not in array form)
Alex-Jordan and others added 6 commits September 21, 2019 13:22
patches #422, after we found that using `\r` as the verbatim delimiter all the time was not workable given how browsers treat `\r`.
Disable autocorrect, autocapitalize, autocomplete, and spellcheck on text inputs
differentiate verbatim delimiter selection
…who depend on a screen reader. TeX output remains plain bold.
CSS files from webwork2/htdocs/css/ in the HTML generate for this
problem.
@taniwallach taniwallach self-requested a review September 25, 2019 13:48
Copy link
Member

@taniwallach taniwallach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been using the WW 2.15 and PG 2.15 (and slightly earlier versions of the code with UTF-8 support) in production for about 6 months. Overall, it works fine.

Several people have tested and remarked at: http://webwork.maa.org/moodle/mod/forum/discuss.php?d=4623

I just made several small PRs to the branch:

Other than #425 which fixes a bug by a sloppy commit or merge, the rest is just "nice to have". If some of the other PRs are not merged soon they can be targeted to develop once all the recent code is merged into develop.

I think we are essentially ready to release PG 2.15 and WW 2.15.

@taniwallach
Copy link
Member

Note: The minor merge conflict is easy to handle.

mgage and others added 7 commits September 25, 2019 20:05
HTML output to use <STRONG> instead of <B> for BBOLD
Fix errors caused by bad merge of tableau.pl
TeX and PreTeXt output, and using the HTML <KBD> tag for HTML output.
No effort was made to allow the use of special characters inside the
unit of content, so it should be used with care.
@taniwallach
Copy link
Member

Unless anyone has any additional urgent changes or objections - I think PG 2.15 is ready for release.
On the WW 2.15 side there are 3 "small" pending PRs:

@drgrice1
Copy link
Sponsor Member

* [openwebwork/webwork2#1026](https://github.com/openwebwork/webwork2/pull/1026)

This pull request could certainly wait until 2.16. There is no urgency for it to go into 2.15.

dpvc and others added 4 commits September 27, 2019 11:34
…lows comparison to use fuzzy tolerance when comparing fractions to explicit decimals. Resolves issue #429
Make promote() use MathObject Real when converting a decimal.  #429
Revert "Make promote() use MathObject Real when converting a decimal.  #429"
@taniwallach
Copy link
Member

As far as I can tell there are no pending PRs or major issues for either pg or webwork2 remaining to hold off the release of 2.15.

The following "minor" issues may need to be addressed with hotfixes:

@mgage mgage merged commit cc7277d into master Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants